[Pkg-xen-devel] [PATCH 09/13] xen init script: move init_dom0 into xenstored start

[Hans van Kranenburg]

On 2/12/19 6:29 PM, Ian Jackson wrote:
> Hans van Kranenburg writes ("[PATCH 09/13] xen init script: move init_dom0 into xenstored start"):
>> This little xen-init-dom0 program is present in both our 4.8 and 4.11
>> packages, so there's no need to keep the if else code. Also, it only
>> makes sense to run it after starting xenstored, and not all other times
>> start is called.
> 
> I think xen-init-dom0 is not in jessie and although skip-upgrades are
> not "supported" I don't see a reason to gratuitously break them.
> Would you mind if we deferred removing this compat code until after
> buster ?

Sure. I was under the impression that "skip-upgrades" were explicitly
unsupported in Debian, and if you do it and it breaks, you just keep the
pieces.

>> @@ -307,11 +299,6 @@ case "$1" in
>>  		0|1) ;;
>>  		*) log_end_msg 1; exit ;;
>>  	esac
>> -	init_dom0
>> -	case "$?" in
>> -		0|1) ;;
>> -		*) log_end_msg 1; exit ;;
>> -	esac
> 
> It would have been less confusing to me if you had separated out the
> change to remove the open-coded fallback, from the change to when this
> is called.

Yes, that's better.

> Also the latter change seems right and here I am complaining about
> the former...

:)

K