[Pkg-xen-devel] Bug#923013: Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A

[Hans van Kranenburg]

Hi Santiago,

First of all, apologies because the tone in my previous message
yesterday may sound a bit hostile. I was tired and happy that we had a
productive day yesterday, getting ~30 bts closed and an upload with a
lot of fixes done, I just did my own rebuild for stretch-backports, and
then the report that it ftbfs came in, and I was too quick with thinking
"no way, I just built it!". :)

Thanks for your report.

On 2/23/19 7:04 AM, Santiago Vila wrote:
> On Sat, Feb 23, 2019 at 01:15:49AM +0100, Hans van Kranenburg wrote:
> 
>> Can you please help me by formulating a clear problem / question and if
>> possible some expected things that you would like to have as a result?
> 
> Sure. This is a packaging bug in debian/rules. Packages must build for the
> end user with plain "dpkg-buildpackage" but also in the official
> autobuilders by doing "dpkg-buildpackage -A" (to generate arch-all
> packages) or "dpkg-buildpackage -B" (to generate arch-indep packages).

I can indeed reproduce the error by doing dpkg-buildpackage -A:

---- >8 ----
dh_missing --fail-missing
dh_missing: etc/bash_completion.d/xl.sh exists in debian/tmp but is not
installed to anywhere
---- >8 ----

This file is installed into the xen-utils-common package as
/usr/share/bash-completion/completions/xl. From
debian/xen-utils-common.install:

---- >8 ----
#! /usr/bin/dh-exec --with=install

[...]

etc/bash_completion.d/xl.sh => usr/share/bash-completion/completions/xl
---- >8 ----

> Either of those failing is a FTBFS bug, hence the serious severity.
> 
> To reproduce the problem, please try building the package with 
> "dpkg-buildpackage -A", which is exactly what the arch:all
> autobuilder would do if the package was uploaded in source-only form.
> 
> The hint of splitting dh_foo into dh_foo-arch and dh_foo-indep usually
> works for packages that use dh and have this bug, i.e. for packages
> which build ok when built with plain "dpkg-buildpackage" but not with
> "dpkg-buildpackage -A" or "dpkg-buildpackage -B".

All of this seems to be related to the dh-exec usage for putting files
in the xen-utils-common package with a different name. This is the first
time this package is using dh-exec.

If I change the following, dpkg-buildpackage -A completes:

---- >8 ----
diff --git a/debian/xen-utils-common.install
b/debian/xen-utils-common.install
index 60642c9a9c..e83dc0740b 100755
--- a/debian/xen-utils-common.install
+++ b/debian/xen-utils-common.install
@@ -2,7 +2,7 @@

 etc/xen/scripts
 etc/xen/xl*
-etc/bash_completion.d/xl.sh => usr/share/bash-completion/completions/xl
+etc/bash_completion.d/xl.sh usr/share/bash-completion/completions

 etc/default/xendomains
 etc/default/xencommons => /etc/default/xen
---- >8 ----

Interestingly, 'etc/default/xencommons => /etc/default/xen' does not
result in a similar error?

I also found this one, which seems to be related:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831786

Do you have an idea / suggestion how we can deal with this?

Hans