[Pkg-xen-devel] Bug#919758: xen-hypervisor-4.8-amd64: Wrong examples provided in GRUB config file

[root]

Package: src:xen
Version: 4.8.5+shim4.10.2+xsa282-1+deb9u11
Severity: minor

Dear Maintainer,

the GRUB configuration file /etc/defaults/grub.d/xen.cfg contains incorrect examples:

1. Bad syntax for dom0 memory allocation settings:

   https://xenbits.xen.org/docs/unstable/misc/xen-command-line.html#list

   Bad syntax (max value is ignored this way): dom0_mem=<size>[M]:max=<size>[M]
   Correct syntax: dom0_mem=<size>[M],max:<size>[M]

2. Bad syntax for earlyprintk usage:

   https://github.com/torvalds/linux/blob/master/Documentation/admin-guide/kernel-parameters.txt

   Bad syntax: earlyprintk=xenboot
   Correct syntax: earlyprintk=xen

Please correct the examples to avoid confusion for users new to Xen (like myself).

Thanks,
Gergely

-- System Information:
Debian Release: 9.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-8-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=UTF-8 (charmap=locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968), LANGUAGE=en_US:en (charmap=locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

xen-hypervisor-4.8-amd64 depends on no packages.

Versions of packages xen-hypervisor-4.8-amd64 recommends:
ii  xen-utils-4.8  4.8.5+shim4.10.2+xsa282-1+deb9u11

xen-hypervisor-4.8-amd64 suggests no packages.

-- Configuration Files:
/etc/default/grub.d/xen.cfg changed:
XEN_OVERRIDE_GRUB_DEFAULT=1
echo "Including Xen overrides from /etc/default/grub.d/xen.cfg"
GRUB_CMDLINE_XEN="dom0_mem=2048M,max:2048M dom0_max_vcpus=1 dom0_vcpus_pin console=vga"
GRUB_CMDLINE_LINUX_XEN_REPLACE="$GRUB_CMDLINE_LINUX earlyprintk=xen console=hvc0"
if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "" ]; then
echo "WARNING: GRUB_DEFAULT changed to boot into Xen by default!"
echo "         Edit /etc/default/grub.d/xen.cfg to avoid this warning."
XEN_OVERRIDE_GRUB_DEFAULT=1
fi
if [ "$XEN_OVERRIDE_GRUB_DEFAULT" = "1" ]; then
GRUB_DEFAULT="Debian GNU/Linux, with Xen hypervisor"
fi