[Pkg-xen-devel] [PATCH 3/9] d/shuffle-binaries: Fix binary shuffling script for cross-building

[Diederik de Haas]

On maandag 30 november 2020 23:31:00 CET Hans van Kranenburg wrote:
> > so use `file` to detect scripts
> > and `strings | grep` for identifying linked libraries.  Even though
> > debhelper depends on file, make the requirement explicit.
> 
> Why would we stop to depend on debhelper? I don't mind to have another
> line with redundancy, but I'm just wondering what your thought behind
> this would be.

I agree with Elliott on this. If you use a command explicitly, you should 
depend on it explicitly. Don't rely on others to do your work. As a bonus, it 
also makes ones own code more logical and easy to follow.
If debhelper would remove its depends on 'file', this script would 'all of a 
sudden' fail, but not when you've made your own depends explicit.

I have no opinion on the rest as I don't what/why that is doing.
I do like making scripts POSIX compliant (though).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20201201/51777fb2/attachment.sig>