[Pkg-xen-devel] [PATCH 8/9] debian/scripts: Optimize runtime scripts

[Diederik de Haas]

On dinsdag 1 december 2020 19:12:56 CET Elliott Mitchell wrote:
> On Tue, Dec 01, 2020 at 04:09:58PM +0100, Diederik de Haas wrote:
> > On maandag 21 september 2020 06:28:53 CET Elliott Mitchell wrote:
> > > +read type < /sys/hypervisor/type
> > > +if [ "$type" != xen ]; then
> > 
> > You should quote 'xen' here too
> 
> That is a style choice and I may find I agree in the future.  Right now
> though "xen" is a *constant* string with no spaces or interesting
> characters, so quoting is completely unnecessary.

It's not wrong and the code should work afaict.

I prefer to make all my scripts validate with shellcheck and that will point 
to https://github.com/koalaman/shellcheck/wiki/Sc2086
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20201202/4eb487bf/attachment.sig>