[Pkg-xen-devel] [PATCH 0/9] RESEND: Fixing cross-compilation, some script work
Elliott Mitchell
ehem+debian at m5p.com
Wed Dec 2 01:51:04 GMT 2020
On Wed, Dec 02, 2020 at 01:52:17AM +0100, Hans van Kranenburg wrote:
> On 12/1/20 3:58 AM, Elliott Mitchell wrote:
> > The modification of tools/pygrub/Makefile didn't split the line
> > on the build target. My reasoning was it had already grown beyond 80
> > columns and had not been line-wrapped, so I left it as-is (likely someone
> > will line-wrap in the future).
>
> Yes, you're adding new information and telling new thoughts, but all of
> this does still not tell me if you spotted a mistake in my cherry-pick fix.
>
> If you think there is one, point it out.
Okay, I see no error in terms of function. On general principle of
staying as close as possible to upstream, there is an error. I imagine
that line will have linebreak(s) added in the future upstream, but it
hasn't happened yet.
Nothing truly urgent.
--
(\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/)
\BS ( | ehem+sigmsg at m5p.com PGP 87145445 | ) /
\_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
More information about the Pkg-xen-devel
mailing list