[Pkg-xen-devel] [PATCH 04/19] d/shuffle-binaries: Add quoting for potentially changeable variables

[Hans van Kranenburg]

On 7/17/20 8:37 AM, Elliott Mitchell wrote:
> These should originate with the owner of a build system and are unlikely
> to get hazardous values.  This script though *should* work on a system
> with such a bizzare setup.  On general principle, add double-quotes.
> 
> Signed-off-by: Elliott Mitchell <ehem+debian at m5p.com>

Yes, this seems to add a little more sanity, or result in less future
complaints about it that only might 'waste time'.

Acked-by: Hans van Kranenburg <hans at knorrie.org>

Fixed up s/bizzare/bizarre/ while committing.

Added to knorrie/sid, thanks.
Hans

> ---
>  debian/shuffle-binaries | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/shuffle-binaries b/debian/shuffle-binaries
> index 31aa01e2bd..8a823da10b 100755
> --- a/debian/shuffle-binaries
> +++ b/debian/shuffle-binaries
> @@ -2,7 +2,7 @@
>  set -e
>  set -o pipefail
>  
> -version=$1; shift
> +version="$1"; shift
>  
>  # We wrap all of the programs in /usr/bin with a script
>  # (xen-utils-wrapper) which chooses the version corresponding to the
> @@ -17,10 +17,10 @@ version=$1; shift
>  list=debian/libxenmiscV.install.vsn-in
>  
>  t=debian/tmp
> -vd=/usr/lib/xen-$version/bin
> +vd="/usr/lib/xen-$version/bin"
>  cd=/usr/lib/xen-common/bin
>  
> -mkdir -p $t/$vd
> +mkdir -p "$t/$vd"
>  
>  for binary in `find $t/usr/{bin,sbin} -type f`; do
>  	reason=''
>