[Pkg-xen-devel] Bug#932759: [PATCH 0/2] Bug#932759 Fix misfiring init scripts

[Hans van Kranenburg]

This should be enough to finally fix the problem of the mysteriously
disappearing xenconsoled process. We have tried to fix this before, but
it turned out the fix was incomplete.

The two attached patches...
* revert the previous fix
* prevent xen-utils-V prerm and postinst to call the xen init script
  when V != running version X.
* remove even more additional extra bonus redundant superfluous
  supererogatory inordinate loquacious start/stop calls from the
  xen-utils-common maintainer scripts, which were put there by
  dh_installinit and went unnoticed so far.

Ian, can you give your A-B on this. It will have to go into buster as
well, to help users upgrade to Bullseye without these problems.

The test scenario I used (all on current Debian unstable):
[x] Reproduce the problem (disappearing xenconsoled) with current
    packages
[x] Install fixed 4.11 packages, and check that when upgrading 4.11 to
    4.11, the init script stop/start is called
[x] Install fixed 4.13 packages, and check that the init script is not
    called when installing xen-utils-4.13 and when upgrading
    xen-utils-common
[x] Reboot into Xen 4.13
[x] Remove xen-utils-4.11 and check that the stop action on the init
    script is not called.
[x] Install xen-utils-4.11 again and check that the start action is
    not called.
[x] Reboot into just Linux without Xen
[x] Remove xen-utils-4.11 and check that this works good enough. It's
    allowed to print some complaints on the screen and behave a little
    weird, but it should not totally explode.

Now, there's a last edge case I can think of, which is installing
xen-utils-V in a domU. In there, the /usr/lib/xen-common/bin/xen-version
script will return the Xen version of the host that is carrying this
domU and then do a thing. I do not think we actively support doing
interesting things inside a domU with these packages however.

Hans van Kranenburg (2):
  xen init/maint scripts: Do nothing if running for wrong Xen package
  debian/rules: --no-start for xen dh_installinit

 debian/rules                       |  2 +-
 debian/xen-utils-V.postinst.vsn-in | 10 +++++++++-
 debian/xen-utils-V.prerm.vsn-in    | 10 +++++++++-
 debian/xen-utils-common.xen.init   | 27 ---------------------------
 4 files changed, 19 insertions(+), 30 deletions(-)

-- 
2.20.1