[Pkg-xen-devel] [PATCH 02/12] debian/rules: Only install PV shim for supported architectures

[Ian Jackson]

Elliott Mitchell writes ("[PATCH 02/12] debian/rules: Only install PV shim for supported architectures"):
> UEFI is available on ARM64 devices, but presently there is no Xen
> configuration for building the PV shim on ARM.  The install step needs
> to match the build step, so modify the install step.

>  	@# shimless arches, so it does not need to be conditional.
> -	$(MAKE) $(make_args_xen) DESTDIR=$t $(make_args_xen) \
> -		-C tools/firmware install-shim
> +	case $(flavour) in \
> +	amd64|i386) \
> +		$(MAKE) $(make_args_xen) DESTDIR=$t $(make_args_xen) \
> +			-C tools/firmware install-shim \
> +	;; \
> +	esac

I don't understand.  The effect of your patch is to avoid running
make install-shim on armhf and arm64.

But on those platforms there is as you say no shim[1], so make
install-shim ought to do nothing.  We build armhf and arm64 on the
Debian buildds from the sources before your patch.

I'm not sure what the connection is between the PV shim and UEFI ?
These are separate concepts.

The PV shim is there to run PV guests in an HVM container, mostly for
Spectre reasons.  There is no shim for ARM because ARM does not have
HVM guests nor PV ones; it has only one type of guest which is roughly
like an x86 PVH guest.

Ian.

-- 
Ian Jackson <ijackson at chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.