[Pkg-xen-devel] [PATCH 03/12] debian/rules: Fix binary shuffling script for cross-building

[Ian Jackson]

Elliott Mitchell writes ("[PATCH 03/12] debian/rules: Fix binary shuffling script for cross-building"):
> `ldd` doesn't work with cross-builds, so use `file` to detect scripts
> and `strings | grep` for identifying linked libraries.

How sad that ldd doesn't work.  I approve of the change to use file,
although maybe that should have a change to build-depends.  (Right now
it seems that debhelper depends on file so this is a theoretical bug
rather than a FTBFS-on-buildd issue.)

> Script almost conforms to POSIX shell standard, so adjust to conform and
> switch to /bin/sh.  Simplify pipe structure, do more work in parent
> shell.

I'm sorry to say that I don't agree with this.  What made you think
there was anything undesirable about using bash in a build system ?

>  set -e
> -set -o pipefail

This, in particular, has quite adverse impacts on error handling.
Also you have reformatted the script.  Reformatting things is usually
to be discouraged.

Sorry,
Ian.