[Pkg-xen-devel] [PATCH 11/16] debian/xendomains.init: Pipe xen-init-list instead of tmp file

Elliott Mitchell ehem+debian at m5p.com
Fri Jan 15 23:18:20 GMT 2021


On Fri, Jan 15, 2021 at 09:45:22PM +0100, Hans van Kranenburg wrote:
> On 12/9/20 11:39 PM, Elliott Mitchell wrote:
> > Shell syntax is has
> 
> > some funky behavior in some areas/ways.
> 
> Being more vague about the reason why this change is necessary is almost
> not possible.
> 
> Sure, I agree that the new code is preferable, but if you make such a
> statement, then at least tell in which case what funky behavior in what
> specific way does something that will do a certain thing wrong, instead
> of letting all future readers wonder whatever you have seen happening
> that you didn't tell about.
> 
> > For these
> > sections /usr/lib/xen-common/bin/xen-init-list should be piped to the
> > loop, rather than creating a temporary file.  This is also pure-Bourne
> > shell syntax, rather than requiring Bash.

Hmm, also goofed in the message, should be "Shell syntax has some..."
the "is" must of snuck in during editing.

Partially this was me looking at the existing scripting and wondering
"Why was this done like this???"   Partially this was, why use
Bash-specific syntax when pure-Bourne syntax works fine?


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg at m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445





More information about the Pkg-xen-devel mailing list