[Pkg-xmpp-devel] jabberd2 review

[Willem van den Akker]

Hi,

Thanks for the comments.
I will make an update en report back.

The XMPP-group never replied to my emails.

Greetings,
Willem

On Wed, 2013-02-27 at 19:42 +0000, Cleto Martín wrote:

> Hi,
> 
> I see following issues:
> 
>  - I would improve debian/copyright, updating it with current
> information (you are now the maintainer) and with the new format. Take a
> look at dh-make template example. I know this should be "pedantic" but I
> consider it important.
> 
>  - I would also remove some bashism from debian/init (and other
> maintainer scripts). See http://mywiki.wooledge.org/Bashism. It is not
> critical but it would be nice for compatibility.
> 
>  - What does debian/prerm? Not sure why it is needed.
> 
>  - Maybe adduser should be at Pre-Depends? (#444620)
> 
>  - I'm not sure if you should to add an entry to debian/NEWS. Think
> about it and decide :-).
> 
>  - Last changelog entry: 's/van/from/', maybe?
> 
>  - You don't have enough energy to change to a pure debhelper packare,
> do you? :-). Well, I prefer that but if you want to use CDBS it's OK for me.
> 
> Rest of package seems to be OK for me. And... well, I've never used
> jabberd2 so I'm a little bit afraid for sponsoring it. But if XMPP group
> doesn't provide you feedback in a week, let me know and we'll see if I
> can sponsor it.
> 
> Cheers,
>  Cleto.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-xmpp-devel/attachments/20130227/2439ea58/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-xmpp-devel/attachments/20130227/2439ea58/attachment.pgp>