[Pkg-xmpp-devel] Bug#742748: jabberd2: fails to build with clang instead of gcc
simon at josefsson.org
Tue Apr 28 13:39:33 UTC 2015
Willem van den Akker <wvdakker at wilsoft.nl> writes:
> On Tue, 2015-04-28 at 12:27 +0200, Simon Josefsson wrote:
>> This patch looks wrong to me -- it changes a void function into an int
>> function, and changes return values from void to 0, which the caller
> I dont see a problem there. It is only used for avoiding errors compling
> with CLANG.
> If or if not a caller ignores a return value is not an issue.
>> As far as I can tell, the patch is not needed at all since
>> upstream has fixed this issue.
> Not in version 2.3.3
I don't follow. What error is there in 2.3.3 that needs to be patched?
I believe the clang_FTBFS_Wreturn-type.diff patch we carried was the
problem that caused the FTBFS, and removing the patch should fix
The bug in 2.2.17 was this line:
The bug is that a void function can't return a value. Gcc warns for
this, clang throws an error.
The line is fixed in 2.3.3:
So the function is a proper void function.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 472 bytes
Desc: not available
More information about the Pkg-xmpp-devel