[Pkg-xmpp-devel] Bug#1150542: /OMEMO GEN generates endless messages of "Could not find own OMEMO device ID. Going to publish own device ID:"

[Alex Schroeder]

Package: profanity
Version: 0.18.2-1+b1
X-Debbugs-CC: stefan at jabber.devlug.de

In order to start using OMEMO I need to generate some information using
/omemo gen. If I do this, some info is printed and after a few seconds,
I get an endless stream of messages, about three or four of them per
second, saying: “Could not find own OMEMO device ID. Going to publish
own device ID: 1579300267”.

I asked around and Stefan told me to look at commit bbd9442db from June
this year:

> fix: query bare JID for PEP features during discovery
> 
> XEP-0163 (Personal Eventing Protocol) states that service discovery
> information queries regarding PEP capabilities must be sent to the users
> bare JID in order to determine support.
> 
> Profanity only queried the server domain JID and its
> generic `disco#items` on connect, but never queried the
> users own bare JID.
> 
> Because ejabberd advertises PEP and PubSub features on both the
> server JID and the bare JID this bug was kind of invisible.
> However, Prosody strictly advertises PEP capabilities only on the users bare JID.
> 
> This discovery failure became a hard blocker for OMEMO on Prosody
> servers following commit `01c781fcf` ("Don't publish keys if the server
> doesn't support pubsub."), which turned the check for publish-options
> into an early-return condition.
> 
> We now query our own bare JID during feature discovery
> on connect and insert it into `conn.features_by_jid`.

I now have a build with that patch and it seems to work!

This is my first time trying to do this so I'm appending what I did
just in case there's some obvious mistake;

Add a `deb-src` section to `/etc/apt/sources.list.d/debian.sources`:

> Types: deb-src
> URIs: http://deb.debian.org/debian/
> Suites: unstable
> Components: main contrib non-free
> Signed-By: /usr/share/keyrings/debian-archive-keyring.gpg

sudo apt install dpkg-dev devscripts
sudo apt update
sudo apt build-dep profanity
mkdir profanity-build
cd profanity-build
sudo apt source profanity
git clone git at github.com:profanity-im/profanity.git
cd profanity
git format-patch bbd9442db^..bbd9442db
cd ../profanity-0.18.2
patch -p1 < ../profanity/0001-fix-query-bare-JID-for-PEP-features-during-discovery.patch
debuild -i -us -uc -b
cd ..
sudo dpkg -i profanity_0.18.2-1_arm64.deb

Testing it: In Profanity, run `/omemo gen` and it seems to work.