<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/4.4.4">
</HEAD>
<BODY>
Hi,<BR>
<BR>
Thanks for the comments.<BR>
I will make an update en report back.<BR>
<BR>
The XMPP-group never replied to my emails.<BR>
<BR>
Greetings,<BR>
Willem<BR>
<BR>
On Wed, 2013-02-27 at 19:42 +0000, Cleto Martín wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Hi,
I see following issues:
- I would improve debian/copyright, updating it with current
information (you are now the maintainer) and with the new format. Take a
look at dh-make template example. I know this should be "pedantic" but I
consider it important.
- I would also remove some bashism from debian/init (and other
maintainer scripts). See <A HREF="http://mywiki.wooledge.org/Bashism">http://mywiki.wooledge.org/Bashism</A>. It is not
critical but it would be nice for compatibility.
- What does debian/prerm? Not sure why it is needed.
- Maybe adduser should be at Pre-Depends? (#444620)
- I'm not sure if you should to add an entry to debian/NEWS. Think
about it and decide :-).
- Last changelog entry: 's/van/from/', maybe?
- You don't have enough energy to change to a pure debhelper packare,
do you? :-). Well, I prefer that but if you want to use CDBS it's OK for me.
Rest of package seems to be OK for me. And... well, I've never used
jabberd2 so I'm a little bit afraid for sponsoring it. But if XMPP group
doesn't provide you feedback in a week, let me know and we'll see if I
can sponsor it.
Cheers,
Cleto.
</PRE>
</BLOCKQUOTE>
<BR>
</BODY>
</HTML>