[Pkg-zfsonlinux-devel] Current status?
Darik Horn
dajhorn at vanadac.com
Tue May 7 06:55:26 UTC 2013
On Mon, May 6, 2013 at 8:46 PM, Carlos Alberto Lopez Perez
<clopez at igalia.com> wrote:
>
> I'm asking you right now to stop making false accusations without any proof.
I'm quoting emails, bug trackers, and commit logs.
> Also we didn't released (yet), so any error on the package isn't a big
> deal. Only before the upload extensive QA should be done.
This excuse perfectly illustrates the basis of our incompatibility.
QA is a continuous process; not a checklist item that you do at
release time or whenever else you feel like it.
>> 3. You left global search-and-replace artifacts at 661c4a4b, which
>> indicates unsafe coding habits.
>>
> ???
> $(MAKE) is the recommend way to call sub-makefiles. Go read:
> https://www.gnu.org/software/make/manual/make.html#MAKE-Variable
Aron fixed your mistake at 01000cbc. It may seem unimportant, but try
to understand why it matters, why it was noticed during review, and
why it means that your submissions must be double-checked for
correctness.
> The way you handle /etc/hostid is broken in many ways:
You resolved a policy violation, but broke the system for some
important 3rd party application software. Rather, you fixated on the
details and missed some critical side-effects.
>> Aron was acting as middle-management here because you were scoring
>> nearly zero in code review, and I didn't want to embarrass you.
>
>This is actually funny :)
No, it is horrifying that you are working in filesystem code and have
a no big deal attitude towards errors and a disdain for QA discipline.
> I'm remembering you that I'm the owner of the ITP on Debian, therefore
> I'm the de-facto maintainer of the package.
After all that pretense about teamwork and collaboration, getting this
dollop of truth is extremely satisfying.
> And I have contributed to Debian more than you did in your whole life.
Perhaps, but implicit in this statement is that merit and quality are
worth less in the Debian organization than seniority or ownership.
> What's wrong with you?
> Why do you come here to make false accusations?
> What are you trying to do?
I want the best possible solution in Debian. I want excellence in
engineering. I want the competition to be fair. And I am very
interested in the outcome of this project.
> If you tried to communicate with me about the above points when I sent
> you the merge requests, we would have get to understand each other. The
> whole idea of sending you merge request was precisely that (discussing
> the code _before_ merging it)
I rejected those merge requests because none of them actually fixed a
bug or implemented an enhancement.
--
Darik Horn <dajhorn at vanadac.com>
More information about the Pkg-zfsonlinux-devel
mailing list