[Pkg-zfsonlinux-devel] Current status?
Darik Horn
dajhorn at vanadac.com
Tue May 7 20:13:59 UTC 2013
On Tue, May 7, 2013 at 2:55 PM, Carlos Alberto Lopez Perez
<clopez at igalia.com> wrote:
>
> So your major complain about my code is that I mistakenly replaced
> "make" with "$(MAKE)" in a *comment* because I use sed to do a global
> replacement on debian/rules?
Yes, because this kind of thing is a used as a heuristic for deciding
whether to double-check submissions, and eventually whether give you
commit privileges.
In this case, it was totally harmless and cosmetic. However, if we
were working in a larger codebase, then this could have introduced
side-effects.
And to be clear, nobody cares about one minor mistake. In this
particular conversation, I bulleted out six objectionable things.
--
Darik Horn <dajhorn at vanadac.com>
More information about the Pkg-zfsonlinux-devel
mailing list