[Pkg-zfsonlinux-devel] About downstream patches on debian packages from zfsonlinux.org repository.

[Turbo Fredriksson]

On Aug 23, 2016, at 12:44 PM, Carlos Alberto Lopez Perez wrote:

> https://etherpad.gnome.org/p/zol-deb-patches


7644 debian/patches/PR1099.patch	- iSCSI
1410 debian/patches/PR1476.patch	- SMB
571 debian/patches/PR2790.patch		- NFS

These three will never, EVER be accepted! It is also unlikely
that a replacement for it will EVER come - it requires _A SUBSTANTIAL_
change and work to both ZED and ZFS! And there is absolutly no
interest in doing the work from anyone.

However, I still maintain these and if accepted, I will continue
to do so. Not that it needs much work, they don't touch anything
that's ever updated.

All three of these have been running in production, not only on
my own server(s), but also others. Not a huge amount, granted,
but enough to warrant them "stable".


The SMB functionality we have in ZoL now is _SERIOUSLY_ (!!!)
broken and almost never works. I wrote that as a test (my first
big C project in 10+ years!) and it was accepted somewhat
prematurely. I then rewrote it in a way that actually works, all
of the time for everyone! As in, going from USER share to REGISTRY
shares.


The current NFS functionality is also quite seriously broken and
doesn't work at all in several occasions (not even _corner_ cases!).


And, of course, the iSCSI functionality doesn't exist at all and
will very likely not be available in upstream in many, many years
to come.


I think it would do our users a great disservice not to include these
three ones!


619 debian/patches/PR1867.patch		- Property Overrides
173 debian/patches/PR2668.patch		- zfs receive additions
110 debian/patches/PR3238.patch		- zfs unshare additions
166 debian/patches/PR3465.patch		- -o feature@<feature>=disable additions

Meh! Good to have, but I'm not married to the idea to have them in.


4881 debian/patches/PR3559.patch	- Refactor SYSV init (Phase 2)
543 debian/patches/PR3560.patch		- Refactor SYSV init (Phase 3)
425 debian/patches/PR3884.patch		- Refactor systemd

Very MEH! In my opinion, the whole init/systemd system in ZoL is
seriously broken and needs serious work. These three is/was supposed
to get us (ZoL) into the game where downstream don't need to do anything.

These are also things that we (downstream) do much better in this
regard and do anyway. Shipping broken init/systemd scripts "just because
it's not in upstream" is IMO ridiculous! We've always created that
ourself anyway.

These three PRs was supposed to make sure that wasn't necessary and
that EVERYONE runs the same code.

But I don't care enough to fight over this. Want to support broken boot,
imports, mounts, shares etc, then feel free to use the upstream ones.
They sure have enough issues regarding that! I (with these patches)
have had none in the last year! They work, and they work VERY WELL!


There is absolutly nothing that dictates that the packages in
Debian GNU/Linux _must_ be _exactly_ like the ones distributed
by upstream. Especially if upstream is [seriously] broken or
lacks [serious] functionality! If we can provide better functionality,
then that's a win for us!
--
As soon as you find a product that you really like,
they will stop making it.
- Wilson's Law

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.alioth.debian.org/pipermail/pkg-zfsonlinux-devel/attachments/20160823/568a596c/attachment.sig>