[Pkg-zfsonlinux-devel] Bug#842237: zfs-share.service tries to call /usr/sbin/rm

[Fabian Grünbichler]

On Thu, Oct 27, 2016 at 12:11:12PM +0200, Petter Reinholdtsen wrote:
> [Fabian Grünbichler]
> > IMHO, that's a step in the right direction, especially for preventing
> > future misplaced files (bindir should not be set to [/usr]/sbin). But
> > note that this moves the scripts from their current location in
> > /usr/sbin to just /sbin (not sure whether this is worth spending extra
> > effort on, especially since usr merge seems to be happening soon?).
> 
> I do not know the code well enough to say if it make sense or not, and
> hope others on the team can have an opinion here.  But given that the
> change is in the automake files, I anyhow believe these changes should
> go into upstream if them make sense.  Perhaps you can try to submit them
> there?
> 

Not sure whether that is desired upstream - all three scripts don't
require root privileges, so it might make sense to put them into
bin_dir (by default). I know that regular users can of course also do
/usr/sbin/arc_summary.py , but AFAIK by default $PATH will not include
/usr/sbin for regular users, which might mean that they miss this
helpful debugging tool.

With the zfs-share.service.in file patched with a hard-coded rm path,
setting bin_dir to '/usr/bin' might actually be the most sane compromise
between Debian and upstream? Anyway, where the python scripts end up and
how they get there is IMHO rather low priority compared to the broken
zfs-share service file.

Anyway, I opened an issue on github[1], waiting for more team and
upstream input seems appropriate.

1: https://github.com/zfsonlinux/zfs/issues/5344