[Pkg-zfsonlinux-devel] Bug#900089: [zfs-dkms]

[Chris Dos]

lsb_release -is = Devuan

Also installed the sysvinit patch:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826994

I deployed a Stretch test system from an upgrade from Jessie along with the
sysvinit patch.  To my surprise, zfs-dkms compiled fine.

So it seams that on the entire server with 1733 packages, only the spl-dkms
zfs-dkms zfs-initramfs zfs-zed require the lsb-release package dependency.

Can this dependency be removed so Devuan and other Debian based distributions
will continue to work with these packages?

Looking at the source:
grep -r lsb_release *
debian/zfs-dkms.dkms:    case `lsb_release -is` in
debian/zfs-dkms.dkms.debhelper:    case `lsb_release -is` in
debian/zfs-dkms/usr/src/zfs-0.7.9/dkms.conf:    case `lsb_release -is` in
So there are three references.

Looking at: debian/zfs-dkms.dkms, debian/zfs-dkms.dkms.debhelper,
debian/zfs-dkms/usr/src/zfs-0.7.9/dkms.conf, all three have the same check.
  --with-linux=$(
    case `lsb_release -is` in
      (Debian)
        if [[ -e ${kernel_source_dir/%build/source} ]]
        then
          echo ${kernel_source_dir/%build/source}
        else
          # A kpkg exception for Proxmox 2.0
          echo ${kernel_source_dir}
        fi
      ;;
      (*)
        echo ${kernel_source_dir}
      ;;
    esac
  )

Is it necessary to use the lsb_release case statement?  Would it not be best
just to use something like this for maximum compatibility with Debian based
distros?
  --with-linux=$(
        if [[ -e ${kernel_source_dir/%build/source} ]]
        then
          echo ${kernel_source_dir/%build/source}
        else
          # A kpkg exception for Proxmox 2.0
          echo ${kernel_source_dir}
        fi
  )


I would like to see the entire debian folder tree go into ZoL source.  Debian
is the core for a lot of distributions and it would be good see a debian
folder added to ZoL source.

I have attached a patch to remove the lsb_release check listed above.
zfs-dkms installed and compiled cleanly on Devuan Jessie, Devuan Ascii
(Stretch), and Devuan Ceres (Sid).

I guess this bug can be changed from Grave to Wishlist, though I hope
lsb_release dependency is removed.

	Chris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_lsb_release_dependency_900089.patch
Type: text/x-patch
Size: 6825 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-zfsonlinux-devel/attachments/20180528/75de48c1/attachment.bin>