[Pkg-zfsonlinux-devel] disable-bpool-upgrade.patch

[Richard Laager]

On 8/14/20 10:09 AM, Colm Buckley wrote:
> I see what Ubuntu were trying to achieve with
> 4100-disable-bpool-upgrade.patch, but I really don't like the hardcoding
> of the "bpool" name into the tools like this.
> 
> Would it be reasonable to adopt this patch (changing the behavior of
> `zpool status` and `zpool upgrade`) if instead of checking for
> name='bpool', it checked for a property; eg: if
> org.debian:grub-workaround = true
Yes, a property would be better. We can bikeshed the name and value. ;)

I'd rather avoid words like "workaround".

Conventionally, ZFS properties tend to be on/off rather than true/false.

Maybe org.debian:grub-features=on?

The long-term upstream plan was to have a "features mask" function, such
that you could do something like `zpool set features=grub bpool`, which
would mask the features (for `zpool upgrade` and the warning in `zpool
status`) to the subset supported by grub. Nobody is currently working on
that.

Maybe org.debian:features=grub?

-- 
Richard