[Pkg-zfsonlinux-devel] Bug#983086: zfsutils-linux: TRIM crashes SSD drives

[Xavier]

Package: zfsutils-linux
Version: 0.8.6-1~bpo10+1
Severity: important

Dear Maintainer,

The recently added cron "TRIM the first Sunday of every month" makes some SSD drives crash.

The problem appears on reasonnably busy and otherwise stable servers:
   * with about 100 containers,
   * each on a separate zvol, ext4 mounted with discard option,
   * on a 6 identical drives raidz2.

The issue has been observed on these drives:
   * Micron_5100_MTFDDAK960TCB
   * Samsung_SSD_850_EVO_1TB
   * Samsung_SSD_860_EVO_1TB

When affected (it not always the case), the systems could not complete the cancelling of the trim with:
# zpool trim -c pool
Testing trim on one drive only, and reducing the rate to as low as 500000, did not help.

A reset seems the only solution, followed by a zpool trim -c after reboot.

It would be wise to deactivate that cron by default, or at least to provide some kind of convenient way to do so, like an option in /etc/default/zfs.

Thank you.

-- System Information:
Debian Release: 10.8
  APT prefers stable
  APT policy: (900, 'stable'), (500, 'stable-updates'), (400, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.19 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages zfsutils-linux depends on:
ii  libblkid1        2.33.1-0.1
ii  libc6            2.31-9
ii  libnvpair1linux  0.8.6-1~bpo10+1
ii  libudev1         241-7~deb10u6
ii  libuuid1         2.33.1-0.1
ii  libuutil1linux   0.8.6-1~bpo10+1
ii  libzfs2linux     0.8.6-1~bpo10+1
ii  libzpool2linux   0.8.6-1~bpo10+1
ii  python3          3.9.1-1
ii  zlib1g           1:1.2.11.dfsg-1

Versions of packages zfsutils-linux recommends:
ii  lsb-base                10.2019051400
ii  zfs-dkms [zfs-modules]  2.0.2-1
ii  zfs-zed                 0.8.6-1~bpo10+1

Versions of packages zfsutils-linux suggests:
pn  nfs-kernel-server           <none>
pn  samba-common-bin            <none>
pn  zfs-initramfs | zfs-dracut  <none>

-- Configuration Files:
/etc/default/zfs changed [not included]
/etc/zfs/zfs-functions changed [not included]

-- no debconf information