[Pkg-zfsonlinux-devel] Bug#1110397: Cause and solution

[Turbo Fredriksson]

The problem have been identified as a commit five (!) years ago
that removed Bashisms.

Bashisms are obviously wrong, so the commit was correct in that
way, but it caused an unforeseen problem with making variables
global, where they needed to be local.

As in, the variable `${fs}` was used in two loops in the main function
to track the file systems to mount, but was overwritten by two support
functions that also used it as a parameter.

See https://github.com/openzfs/zfs/issues/17963#issuecomment-3596171871
and the solution is to rename those function and make their use
of the `${fs}` variable unique. As in, renaming it in the functions.

A patch have been proposed, see https://github.com/FransUrbo/zfs/commit/8b79a6e231d2dd88e360d1ad114b8fcac6029be2,
which are included in this PR (which also does some code
cleanup):

https://github.com/openzfs/zfs/pull/18000