[Pkg-zsh-devel] RFS: oh-my-zsh/0~20140211-1 [ITP]

[Jerome Charaoui]

Hi Alex,

Thank you for the thoughtful comments. I have taken everything into
consideration. I'm still committed to bringing an oh-my-zsh package into
Debian.


Le 2014-03-07 07:38, Axel Beckert a écrit :
>>> Most issues I found so far seem to be not packaging related:
>>>
>>> "oh-my-zsh-config --install" does not check if I have already zsh as
>>> login shell and calls chsh unconditionally
>>>
>>> Likewise "oh-my-zsh-config --uninstall" wants to change my login shell
>>> to bash despite it never was bash. It should e.g. honour if the user
>>> had zsh or tcsh previously.
>>
>> The install.sh and uninstall.sh scripts provided in oh-my-zsh are really
>> not pretty. I think my preffered solution would be to simply *not* ship
>> these scripts, and instead further document usage of oh-my-zsh in
>> README.Debian. Would this be acceptable?
> 
> Sure.
> 
> It's a good question, though. Using README.Debian is probably less
> error-prone, but the idea of scripts is neat for those who don't want
> to fiddle themselves with config files, especially because I suspect
> quite some of these people in the (potential) oh-my-zsh user base and
> hence part of what people expect from oh-my-zsh. Difficult to say
> what's the "better" way.
> 
> Maybe install the scripts as documentation or examples for now and
> when you think, they're mature enough, put them back into /usr/bin/.
> 
> Those scripts seem not to be patched heavily, so it seems as if that
> chsh feature is from upstream. If I would be you, I'd forward that
> issue to upstream, maybe they fix it for you. :-)

I've submitted a patch upstream to fix this shell switching issue. See
this pull request : https://github.com/robbyrussell/oh-my-zsh/pull/2626
If you get a chance to try it out and report your results, it would be a
big help. As for the package, I'm not enclined to carry it around in the
debian/patches.

In the mean time I have removed the oh-my-zsh-config executable. I plan
on reintegrating it when (un)install scripts get fixed upstream.


> One more comment about the patches as I had a closer look for checking
> what's from the original install/uninstall scripts and what's patched:
> 
> From 03-Strip-download-removal-of-omz-in-home-directory.patch:
> 
> -cp ~/.oh-my-zsh/templates/zshrc.zsh-template ~/.zshrc
> +cp /usr/share/doc/oh-my-zsh/examples/zshrc.zsh-template ~/.zshrc
> 
> You use a file under /usr/share/doc/ for functionality. That violates
> Policy §12.3: "Packages must not require the existence of any files in
> /usr/share/doc/ in order to function. Any files that are referenced by
> programs but are also useful as stand alone documentation should be
> installed under /usr/share/package/ with symbolic links from
> /usr/share/doc/package." See
> https://www.debian.org/doc/debian-policy/ch-docs.html#s12.3 for the
> full text.
> 
> Background is that the system administrator should be able to delete
> files in /usr/share/doc/ without causing any programs to break.
> Actually there are some Debian derivatives who do that, Maemo for
> example but IIRC also one or more of the Emdebian flavours.

Agreed. No longer an issue now that oh-my-zsh-config is out of the way,
but I will make sure to fix this when it is reintroduced.

I believe the now updated package on mentors adresses all of the issues
you've raised. I would very much appreciate further review, and if
everthing checks out, sponsorship.

https://mentors.debian.net/package/oh-my-zsh

Thanks,

-- Jerome