[Pkg-zsh-devel] RFS: oh-my-zsh/0~20140211-1 [ITP]

[Jerome Charaoui]

Le 2014-05-11 19:59, Axel Beckert a écrit :
> sorry for the late reply, but March/April is always a busy time of the
> year for me with a lot of travelling.

No problem, I'm generally quite busy as well.


> One thing I noticed there is that zsh may also be installed as zsh4,
> zsh5, zsh-static or zsh-beta, i.e. the user's shell may be named not
> exactly zsh. But I don't know how common these values are. Debian
> shipped a zsh-beta package until Wheezy. IIRC in the past Debian
> shipped an /etc/shells which only allowed /bin/zsh4 as login shell,
> but not /bin/zsh.

I'll keep that in mind if I eventually decide to backport the package or
wheezy. I don't think that's an issue for jessie, which is what I'm
aiming at currently.


> Missing licenses
> ================

I've added the license for theme_chooser.sh. I also created issues for
wd and zsh-git-prompt asking for licensing info. I wrote to Zach Holman,
author of cloudapp.rb.

Regarding that last piece of software, even though the clipboard
function won't work on Linux (pbcopy seems to be Mac-specific), it does
other useful things like upload the file and print the URL on the
console. It's that URL which is copied to the clipboard  for
convenience. I think we should keep it in there.


> Since licenses is one of the things the FTP masters will look at
> closely to make sure only free software enters Debian, we should be
> picky here, too.

Agreed.


> Functionality issues
> ====================

> Both errors are gone if I source /usr/bin/oh-my-zsh-theme-chooser
> instead of calling it as a command. This is likely because it hasn't
> sourced my .zshrc and hence $ZSH wasn't defined. (Maybe $ZSH should be
> exported for that to work?)

It does need to be exported! Incidentally, this has been very recently
fixed in the upstream version of the template file.


> It would be annoying to have such error messages in the prompt for all
> users not using rvm.

It seems many (all?) themes expect a certain set of depencies (git is a
popular one), and fail hard if they aren't available. Furthermore,
oh-my-zsh doesn't seem to have any sort of method for declaring and
verifying theme dependencies, so modifying theme_chooser.sh to only
offer fully-functional themes doesn't seem doable without introducing a
special header to all of them. I don't think I want to spend days fixing
every theme's error handling, either...

I agree with you, however, that it isn't feasible to ship the script
as-is in Debian.

A more acceptable, but still non-ideal, solution would be to remove
theme_chooser.sh and point users who wish to preview oh-my-zsh themes to
https://github.com/robbyrussell/oh-my-zsh/wiki/themes

What do you think?


> Nice to have
> ============
> 
> A minor issue, but potentially annoying: Reading Textile markup is not
> very comfortable IMHO, so instead of installing upstream's
> README.textile directly you may run it through pandoc first:

Good idea! The result is indeed more readable than the textile source.

I'll let you know when I have a new version of the package ready for review.


Thanks for your continued input in this,

-- Jerome

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 534 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-zsh-devel/attachments/20140529/f3e1d080/attachment.sig>