[Pkg-zsh-devel] Bug#844076: zsh: FTBFS (failing tests)

[Santiago Vila]

Package: src:zsh
Version: 5.2-5

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
touch stamp-h.in
dh_autotools-dev_updateconfig
dh_autoreconf
dh_testdir
chmod 755 configure
mkdir -p obj/testhome
dh_auto_configure -B obj -- --prefix=/usr --mandir=/usr/share/man --bindir=/bin LDFLAGS="-Wl,--as-needed -g -fPIE -pie -Wl,-z,relro -Wl,-z,now" --infodir=/usr/share/info --enable-maildir-support --enable-max-jobtable-size=256 --enable-etcdir=/etc/zsh --enable-function-subdirs --enable-site-fndir=/usr/local/share/zsh/site-functions --enable-fndir=/usr/share/zsh/functions --with-tcsetpgrp --with-term-lib="ncursesw tinfo" --enable-cap --enable-pcre --enable-readnullcmd=pager --enable-custom-patchlevel=Debian --enable-additional-fpath=/usr/share/zsh/vendor-functions,/usr/share/zsh/vendor-completions --disable-ansi2knr
	../configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --mandir=/usr/share/man --bindir=/bin "LDFLAGS=-Wl,--as-needed -g -fPIE -pie -Wl,-z,relro -Wl,-z,now" --infodir=/usr/share/info --enable-maildir-support --enable-max-jobtable-size=256 --enable-etcdir=/etc/zsh --enable-function-subdirs --enable-site-fndir=/usr/local/share/zsh/site-functions --enable-fndir=/usr/share/zsh/functions --with-tcsetpgrp "--with-term-lib=ncursesw tinfo" --enable-cap --enable-pcre --enable-readnullcmd=pager --enable-custom-patchlevel=Debian --enable-additional-fpath=/usr/share/zsh/vendor-functions,/usr/share/zsh/vendor-completions --disable-ansi2knr
configure: WARNING: unrecognized options: --disable-silent-rules, --disable-maintainer-mode, --disable-dependency-tracking, --enable-max-jobtable-size
configuring for zsh 5.2
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu

[... snipped ...]

Running test: -N cond
This test takes two seconds...
Test ../../Test/C02cond.ztst failed: bad status 1, expected 0 from:
  print -u $ZTST_fd 'This test takes two seconds...'
  sleep 2
  cat $unmodified
  touch $newnewnew
  if [[ $OSTYPE == "cygwin" ]]; then
    ZTST_skip="[[ -N file ]] not supported on Cygwin"
  elif (( isnfs )); then
    ZTST_skip="[[ -N file ]] not supported with NFS"
  elif test -f /etc/mtab && { grep $(df . 2>/dev/null| tail -n1 | awk '{print $1}') /etc/mtab | grep -q noatime; }; then
    ZTST_skip="[[ -N file ]] not supported with noatime file system"
  else
    [[ -N $newnewnew && ! -N $unmodified ]]
  fi
Was testing: -N cond
../../Test/C02cond.ztst: test failed.
The following may (or may not) help identifying the cause:
  This test can fail on NFS-mounted filesystems as the access and
  modification times are not updated separately.  The test will fail
  on HFS+ (Apple Mac OS X default) filesystems because access times
  are not recorded.  Also, Linux ext3 filesystems may be mounted
  with the noatime option which does not update access times.
  Failures in these cases do not indicate a problem in the shell.
../../Test/C03traps.ztst: starting.

[...]

Test successful.
Running test: a and b
Test successful.
Running test: three arguments
Test successful.
Running test: first argument
Test successful.
Running test: -+
Test successful.
Running test: option beginning with + and -.
Test successful.
Running test: two option arguments
Test successful.
Running test: sticky option argument
Test successful.
Running test: end of option sequence
Test successful.
Running test: argument beginning with minus
Test successful.
Running test: optional option argument
Test successful.
Running test: variable length option arguments
Test successful.
Running test: opt_args
Test successful.
Running test: rest arguments
Test successful.
Running test: words array in rest arguments
Test successful.
Running test: opt_args
Test successful.
Running test: options and words (zsh-workers:12257)
Test successful.
../../Test/Y03arguments.ztst: all tests successful.
**************************************
46 successful test scripts, 1 failure, 0 skipped
**************************************
Makefile:189: recipe for target 'check' failed
make[2]: *** [check] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj/Test'
Makefile:265: recipe for target 'test' failed
make[1]: *** [test] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj'
dh_auto_test: make -j1 test VERBOSE=1 returned exit code 2
debian/rules:52: recipe for target 'build-arch' failed
make: *** [build-arch] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

The relevant part of the build log is included above.

The build was made on a QEMU/KVM virtual machine using sbuild and union-type=overlay.

I'm filing this as "normal" because I believe this to be an artifact
of using sbuild with overlayfs. The test itself says it may fail
on NFS. Would this be a bug if we were using NFS instead of sbuild
with overlayfs? If not, feel free to downgrade to wishlist, but it
would be nice if this never failed anyway so that I don't have to
special-case this package in my test builds.

Thanks.