[Pkg-zsh-devel] Bug#871787: Bug#871787: zsh: error "defining function based on alias ..."

[Axel Beckert]

Control: clone -1 -2
Control: retitle -2 zsh: error "defining function based on alias ..."
Control: tag -2 - moreinfo unreproducible + confirmed pending

Hi Vincent,

Vincent Lefevre wrote:
> > So you should either add this option or change the syntax of your
> > startup scripts. I hence consider this to be a non-bug.
> 
> OK, but perhaps this should be announced then,

Granted. Actually I thought about that already, too. Cloning the bug
report for that then.

Currently planned text in /usr/share/doc/zsh/NEWS.Debian.gz:

zsh (5.4.1-1) unstable; urgency=medium

  Zsh version 5.4.1 introduced a change which doesn't allow aliases and
  functions of the same name by default:

  > commit bb218704d27bcca9aa4426296dcd5c13d58b330a
  > Author: Peter Stephenson <p.w.stephenson at ntlworld.com>
  > Date:   Tue Jan 10 19:14:26 2017 +0000
  >
  >     40306 with doc tweaks: Change behaviour expanding alias in ()
  >     function definition.
  >
  >     Now an error unless the () is part of the same error as the name.
  >     Add ALIAS_FUNC_DEF option to allow it again.

  The common error message triggered by this change looks as follows:

  > zsh: defining function based on alias `foo'
  > zsh: parse error near `()'

  See https://bugs.debian.org/871787 for more information.

 -- Axel Beckert <abe at debian.org>  Fri, 11 Aug 2017 21:43:25 +0200

Do you think that suffices? (I'll update the bug report number
accordingly once this bug report is cloned.)

> since there are legitimate uses and this is a change in the
> behavior.

Admittedly I'm not totally convinced of that, but since it's defacto
an additional syntax restriction, it validates an NEWS.Debian entry.

> In my case, this is typically something like:
> 
> alias ssh='nocorrect ssh'
> 
> and a ssh wrapper is defined as a function. I don't see anything
> wrong with this kind of construct.

Hrm. Doesn't it suffice to put nocorrect into the function?

> > Works fine for me on a first glance, both without arguments as well as
> > with the beginning of a command already typed.
> 
> I'll try to find the cause of the other issues.

Thanks!

Do all man completions fail or just some (e.g. with specific options
or so)?

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE