[Pkg-zsh-devel] zsh-syntax-highlighting 0.6.0~rc1-1 uploaded to mentors.debian.net

[Axel Beckert]

Hi Daniel,

Daniel Shahaf wrote:
> mentors.debian.net wrote on Mon, 31 Jul 2017 20:36 +0000:
> > Your upload of the package 'zsh-syntax-highlighting' to mentors.debian.net was
> > successful. Others can now see it. The URL of your package is:
> > https://mentors.debian.net/package/zsh-syntax-highlighting
> > 
> > The respective dsc file can be found at:
> > https://mentors.debian.net/debian/pool/main/z/zsh-syntax-highlighting/zsh-syntax-highlighting_0.6.0~rc1-1.dsc
> 
> I've just uploaded a z-sy-h release candidate (for experimental) to mentors

Ah, now that's a good reason to get to my long-time open todo to look
through your work for being able to give you upload permissions for
zsh-syntax-highlighting with a clear conscience. :-)

The first thing I ran into was that I couldn't verify the GPG
signature on the .dsc:

→ gpg --keyring /usr/share/keyrings/debian-maintainers.gpg --verify zsh-syntax-highlighting_0.6.0~rc1-1.dsc
gpg: Signature made Mon Jul 31 22:24:46 2017 CEST
gpg:                using RSA key 6EB60B637CE5ACBF2449A2DADB27E997429AF20C
gpg: Can't check signature: No public key

Reason is that while you updated your key wrt. to the expiry date on
the usual public keyservers, the update seems not included in the
debian-keyring package (yet):

→ gpg --keyring /usr/share/keyrings/debian-maintainers.gpg --list-keys shahaf
pub   rsa3072/A5FEEE3AC7937444 2013-06-11 [SC] [expired: 2017-06-11]
      E96646BE08C0AF0AA0F90788A5FEEE3AC7937444
uid                 [ expired] Daniel Shahaf <d.s at daniel.shahaf.name>
uid                 [ expired] Daniel Shahaf <danielsh at apache.org>
sub   rsa3072/07A5FDB6BF284327 2013-06-11 [E] [expired: 2017-06-11]

So you should probably send the updated key also to Debian's key
server. See the section "Updating your key(s)" in
/usr/share/doc/debian-keyring/README.gz.

> It was a little trickier than I'd expected since I had to do a minor
> history surgery (details in the log messages),

Indeed sounds hairy. But looks well solved to me. I like the verbose
commit message with the ascii-art-ish history tree.

> but anyway, I'm looking for volunteers to sponsor this.

Looks mostly fine.

Things which should be fixed before uploading:

W: zsh-syntax-highlighting: debian-changelog-line-too-long line 4

Some comments about the remaining lintian warnings:

I: zsh-syntax-highlighting source: debian-rules-parses-dpkg-parsechangelog (line 20)
I: zsh-syntax-highlighting source: debian-rules-parses-dpkg-parsechangelog (line 21)

Lintian is probably right, but that's nothing urgent at all IMHO.

P: zsh-syntax-highlighting source: debian-watch-may-check-gpg-signature

Mostly target towards upstream, but since you're also upstream...
I'd sponsor it without a fix for that, nevertheless. But you might
want to look into that at some point in the future. :-)

Anyway, I hopefully managed to give you DM upload permissions for
zsh-syntax-highlighting. (Sorry, it took so long.)

You might need to update your key in the debian-maintainer keyring
before uploading, though. If that's not possible soon-ish (IIRC it's
not the package state which is relevant, but the current state on the
Debian servers, but I'm not 100% sure), I can one more sponsor an
upload.

I also assume that you don't actually want 0.6.0~rc1-1 to be uploaded
but maybe 0.6.0-1 or so. At least I saw the start of 0.6.0~rc1-2 in
git. (Just tell me if I'm wrong here. But then again, that overlong
line should be fixed before uploading anyways.)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-zsh-devel/attachments/20170731/84c27686/attachment.sig>