[Pkg-zsh-devel] Bug#902526: Bug#902526: Bug#902526: zsh-syntax-highlighting: FTBFS in buster/sid (does not work with recent debhelper)

[Daniel Shahaf]

Axel Beckert wrote on Wed, 27 Jun 2018 15:19 +0200:
> Hi,
> 

Thanks for having a look, Axel.

> Daniel Shahaf wrote:
> > > dh_installchangelogs
> > > rm debian/zsh-syntax-highlighting/usr/share/doc/zsh-syntax-highlighting/changelog.md
> > > rm: cannot remove 'debian/zsh-syntax-highlighting/usr/share/doc/zsh-syntax-highlighting/changelog.md': No such file or directory
> > > debian/rules:14: recipe for target 'override_dh_installchangelogs' failed
> > > make[1]: *** [override_dh_installchangelogs] Error 1
> > 
> > I'm guessing that debhelper on buster installs that file as
> > /usr/share/doc/.../changelog.md.gz or something,
> 
> It is only installed as
> /usr/share/doc/zsh-syntax-highlighting/changelog at that time.
> 
> Not sure why the path used by the upstream build system to install it,
> seems no more present.
> 

That's odd.  Upstream's 'make install' does 'cp changelog.md $(DOC_DIR)'
and that part hasn't changed between 0.5.0 (stretch) and 0.6.0 (buster).  It's even
the same in upstream's HEAD.

> > but I don't have a buster build env handy to investigate. Is someone
> > able to look into this?
> 
> Done: Dropping override_dh_installchangelogs already suffices to make
> the package build again.
> 
> I though wonder if that isn't actually a regression in a recent
> debhelper release.

You mean, a regression whereby debhelper removes the .md suffix
overzealously?  According to debhelper's own changelog, there have been
several changes to dh_installchangelogs in debhelper 11.3{,.1,.2}, so a
regression is not inconceivable.  However, all those mentions of
'upstream changelogs' in dh's own changelog make me wonder if dh got smarter,
is recognising changelog.md as an upstream changelog, and by itself avoids installing
changelog twice --- which makes the 'rm' in z-sy-h's d/rules redundant.
If that's the case, then removing the override_dh_installchangelogs
target would be the correct fix.

Does this make senes?

Thanks again,

Daniel