[Pkg-zsh-devel] Bug#909114: Bug#909114: Bug#909114: Bug#909114: Bug#909114: Check for missing pcre module

[Daniel Shahaf]

Control: tags -1 upstream

Axel Beckert wrote on Wed, Sep 19, 2018 at 00:48:42 +0200:
> Hi Daniel,
> 
> Daniel Shahaf wrote:
> > I came up with this, but when I applied it to 5.6.2-2 the build didn't fail as
> > I expected it to.  Does anyone see the problem?
> > 
> > [[[
> > diff --git a/Test/V07pcre.ztst b/Test/V07pcre.ztst
> > index 9feeb47fb..ab67f3d80 100644
> > --- a/Test/V07pcre.ztst
> > +++ b/Test/V07pcre.ztst
> > @@ -1,11 +1,10 @@
> >  %prep
> >  
> > -  if ! zmodload -F zsh/pcre C:pcre-match 2>/dev/null
> > +  if grep '^name=zsh/pcre .* link=no ' $ZTST_testdir/../config.modules >/dev/null
>                                                        ^^^^
> 
> Maybe because we build out of tree:
> 
> ~/zsh/zsh → find . -name config.modules
> ./obj-static/config.modules
> ./obj/config.modules

I don't think that's it.

One, $ZTST_testdir/../Src/zsh is used all over the place to refer to the
just-built zsh binary, so $ZTST_testdir/../ must be the build tree.

Two, I did test it in my normal, static, out-of-tree build, and it behaved as
expected.  However, when I applied it to 5.6.2-2 (from 'apt-get source', not
git) and rebuilt, the build passed.

Oh!  I see.  What must have happened is: configure failed to detect libpcre, so
it set link=no config.modules, so the grep matched and the test skipped.  In
other words, the test skipped (and therefore the build passed) because we
haven't done the corresponding configure.ac fix.

I'll send the V07 patch upstream.  Shall we leave this bug open to track the
autoconf work that needs doing?  (That work, too, is upstreamable; tagging
accordingly.)

Cheers,

Daniel