[Pkg-zsh-devel] Bug#962135: Bug#962135: patch for bugs 962133 and 962135

[Axel Beckert]

Hi Vincent,

Vincent Lefevre wrote:
> I've attached a patch for Debian bugs 962133 ("dpkg -s" completion)
> and 962135 ("dpkg -l" completion), which also fixes "dpkg --remove"
> and "dpkg --purge" completions.

Thanks for the patch!

Daniel: Would you review it for upstream inclusion?

> I've added a note about that:
> 
> # Note: Packages may be marked as "deinstall" or "purge", i.e. selected
> # for deinstallation or to be purged (see dpkg(1) man page); this means
> # that the operation has not been completed yet. In the meantime, such
> # packages may still be installed (if marked as purge, one is not sure,
> # though, as the package could have been uninstalled but not purged yet),
> # so that purge and remove operations remain valid.

*sigh* IMHO this is highly misleading.

The difference between dpkg "states" (i.e. the current state) and
"selection states" (i.e. the wanted state) only matters if you use
dselect, which nearly nobody does nowadays.

So please do _not_ refer to "selection states" in such places since
"selected for deinstallation" always sounds as if deinstallation is
imminent while it in 99.9% of all cases already has happened, possibly
even years ago.

> My patch also removes "deinstalled" from _deb_packages as it does not
> seem to be used (and should be useless).

Not sure if this is wanted. That code might have been made "complete"
on purpose for 3rd-party (or future internal) usage. I'd not remove it.

Nevertheless good to know that it doesn't seem to get used in zsh
internally currently.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE