[Pkg-zsh-devel] fizsh embeds a copy of z-sy-h

[Daniel Shahaf]

Good morning all,

I've just noticed that fizsh includes a copy of z-sy-h:

    https://codesearch.debian.net/search?q=ZSH_HIGHLIGHT_REVISION&literal=1

However, Policy says packages "should not" include convenience copies
of other packages:

    §4.13
    .. _s-embeddedfiles:
    
    Convenience copies of code
    --------------------------
    
    Some software packages include in their distribution convenience copies
    of code from other software packages, generally so that users compiling
    from source don't have to download multiple packages. Debian packages
    should not make use of these convenience copies unless the included
    package is explicitly intended to be used in this way.  [#]_ If the
    included code is already in the Debian archive in the form of a library,
    the Debian packaging should ensure that binary packages reference the
    libraries already in Debian and the convenience copy is not used. If the
    included code is not already in Debian, it should be packaged separately
    as a prerequisite if possible.  [#]_

Further information:

- With my z-sy-h upstream hat, I don't mind z-sy-h upstream being
  included in fizsh upstream.

- The fizsh package doesn't have autopkgtest support; the z-sy-h package
  does.  Thus, avoiding the convenience copy would let fizsh users
  benefit from as-installed testing support.

- fizsh sets $ZSH_HIGHLIGHT_VERSION and $ZSH_HIGHLIGHT_REVISION to empty
  values.  I consider this a bug.

What's the proper way to handle all this?  One bug report about removing
the interpackage duplication (what severity?) and another about fixing
the version information?

Cheers,

Daniel