[Pkg-zsh-devel] zsh FTBFS under Salsa CI's reprotest: 'KEY_EVENT' undeclared / blhc CI check disabled / bullseye freeze: zsh is considered a key package

[Axel Beckert]

Hi Daniel,

Daniel Shahaf wrote:
> > P.S.: I wonder if the other, more obscure test suite failure — which
> > only happens inside the reprotest check on Salsa CI, too — is also
> > related to eatmydata. Unfortunately the debug output is not as verbose
> > as in P01privileged.ztst. Like maybe like it is just checked for some
> > empty output, but it actually contains "ERROR: ld.so: object
> > 'libeatmydata.so' from LD_PRELOAD cannot be preloaded (cannot open
> > shared object file): ignored." and the test suite thinks the test
> > failed because there was any output from some globbing routine.
> 
> Pointer to the "other, more obscure test suite failure", please?

Citing from https://salsa.debian.org/debian/zsh/-/jobs/1066149#L6632:

Running test: unreadable directories can be globbed (users/24619, users/24626)
Test ../../Test/D02glob.ztst failed: test was expected to fail, but passed.
Was testing: unreadable directories can be globbed (users/24619, users/24626)
../../Test/D02glob.ztst: test failed.
../../Test/D03procsubst.ztst: starting.

See also my bug report against the Salsa CI pipeline:
https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/181

> > P.P.S.: I also wonder if that missing KEY_EVENT thingy could also be
> > triggered by not being able to load some arbitrary .so file.
> 
> I don't see how, but I suppose it won't hurt to grep «configure &&
> make»'s log/debug output for eatmydata errors.

Yeah, I should probably setup a chroot without eatmydata installed.
I'm admittedly currently too lazy to do that…

> And note that once the upstream commit you cherry-picked to your branch
> is merged (whether by being cherry-picked or by packaging 5.9), the
> failure mode will change: the added «#ifdef KEY_EVENT» will silently
> evaluate to false, with little consequence.

Well, currently for me the main point is that the build no more fails
with it on Salsa CI, just the test suite. Since I'm not sure if this
has other implications, I rather used a feature branch for these
experiments.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE