[Popcon-developers] Bug#365681: popcon: using http_proxy

[Bill Allombert]

On Fri, Nov 30, 2007 at 12:34:53PM +0100, Petter Reinholdtsen wrote:
> [Bill Allombert]
> > I propose we apply the attached patch to fix bug #365681.
> 
> Why not use http_proxy directly instead of HTTP_PROXY?  It should be
> enough to specify that http_proxy can be set in
> /etc/popularity-contest.conf, and then just export it if it is set.

Using upper case is more consistent with the other options, and does not
stomp on system-wide environment variable.

Using http_proxy might also induce people to believe that system-wide
http_proxy is not honored.

> Introducing HTTP_PROXY might just increase confusion, for those that
> know about http_proxy.

If people know about http_proxy, they know it needs to be exported and
will write
export http_proxy="http://foo:bar"
which will work.

Other people might wonder why http_proxy is in lower-case.

Cheers,
Bill.