[Popcon-developers] [PATCH] Clean up the shell scripts

[Bill Allombert]

On Sun, Oct 25, 2015 at 01:09:43PM +0800, Paul Wise wrote:
> @@ -72,15 +72,15 @@ run_popcon()
>  do_sendmail()
>  {
>  	if [ -n "$MAILFROM" ]; then
> -		sendmail -oi $MTAOPS -f "$MAILFROM" $MAILTO
> +		sendmail -oi "$MTAOPS" -f "$MAILFROM" "$MAILTO"
>  	else
> -		sendmail -oi $MTAOPS $MAILTO
> +		sendmail -oi "$MTAOPS" "$MAILTO"
>  	fi

Hello Paul,
Please see the FAQ:

  Q) How can I pass extra options to sendmail ?
  
  A) Add a line in /etc/popularity-contest.conf as follow
  MTAOPS="-opt1 -opt2 -opt3"
  
  Q) How can I prevent popularity-contest from sending reports via email?
  
  A) This is not recommended. Reports are sent by email only when the HTTP

Once your patch is applied, this will not work anymore.

I am unsure about what you tried to do.

Thanks for your effort!
-- 
Bill. <ballombe at debian.org>

Imagine a large red swirl here.