[Python-apps-team] RFS: cgmail (adopted)

[Dmitrijs Ledkovs]

Hello

sorry that it took so long. Have been busy....

2009/2/21 Sandro Tosi <morph at debian.org>:
> Hi Dmitrijs,
> I finally had some time to check at your package:
>
> On Tue, Feb 17, 2009 at 00:04, Dmitrijs Ledkovs
> <dmitrij.ledkov at gmail.com> wrote:
>>
>> * Updated Maintainers field to PAPT
>> * Set myself in Uploaders
>> * Update VCS-* fields to point to svn
>
> none of this changes has been documented in debian/changelog. Please
> use this file to report every change you made from the previous
> package to the current one.
>

I now write more detailed changelog entries.

> debian/changelog:
> - explain why you're removing lib/feedparser.py even here.
>

It now says this:

  * debian/patches/
    - remove-feedparser.patch
      Removes lib/feedparser.py (lintian tag convenience copy of code)


> debian/control:
> - the short description needs better improvement ("new shiny" is not
> to be here, and 'A ' is wrong for short descr (cfr devref on it))

New description. Is it better / worse? (English is not my first language btw)

Description: small email checker for the GNOME desktop
 Unintrusive email checker with extended Gmail (Google mail) support. It
 supports conventional IMAP and POP3 accounts as well. It provides a
 notification icon in the system tray as well as pop-up notifications when new
 mail arrives. It can also be setup to check new mail in Gmail labels. Does not
 require a mailing application or Gmail kept open in the background.

> - why b-d-i on 'perl'? "grep -riw perl *" returns nothing on the top
> level dir of upstream tarball

I wrote manpages in pod format. And pod2man turns them into nroff
manpages. Pod2man is part of perl package.

> - it's an arch:all packages, can't some other packages be moved to b-d-i?
>

Moved. Clean target must be satisfied by build-depends (lintian) so
this is how control looks now:

Build-Depends: debhelper (>= 7),
               python,
               cdbs
Build-Depends-Indep: perl,
                     python-support,
                     python-setuptools,
                     python-distutils-extra (>= 1.91)


> debian/NEWS:
> - please use the same format of debian/changelog, dch --news is your
> friend (too much indentation, to name one).
>

I hope I got it right......

> debian/rules:
> - why "rm $(CURDIR)/debian/pycompat" ?
>

Dunno..... cdbs still creates it, but clean target doesn't remove it.
Anyways I've removed this line now.

> debian/watch:
> - you can remove the empty bottom lines in this file
>

removed

> $ lintian -iIv --pedantic cgmail_0.5-1_amd64.changes
>

yeap done. Although my lintian is still 2.2.5 (Failing to create
pbuilder sid). It is -I -E -i --pedantic clean.

> gives something to work on (v2.2.5).
>
> Get back to me/us (on irc at #debian-python on irc.debian.org even
> better) once a new package is ready (no need to upload to mentors, we
> build from svn).
>

Everything is in svn.

cheers.

> Regards,
> --
> Sandro Tosi (aka morph, morpheus, matrixhasu)
> My website: http://matrixhasu.altervista.org/
> Me at Debian: http://wiki.debian.org/SandroTosi
>

-- 
With best regards


Dmitrijs Ledkovs (for short Dima),
Ледков Дмитрий Юрьевич