[Python-apps-team] RFS: s3ql (new python application)

[Kilian Krause]

Hi Nikolaus,

On Mon, Jun 27, 2011 at 03:15:49PM -0400, Nikolaus Rath wrote:
> > 1. You use quilt as build-depends. This should not be neccessary with
> > dpkg-source v3.
> 
> It seems to be. Without quilt:
> 
> dh clean --with python2,quilt
> dh: unable to load addon quilt: Can't locate Debian/Debhelper/Sequence/quilt.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.12.3 /usr/local/share/perl/5.12.3 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.12 /usr/share/perl/5.12 /usr/local/lib/site_perl .) at (eval 23) line 2.
> BEGIN failed--compilation aborted at (eval 23) line 2.

my suggestion would be the same as Arno already pointed out. The "--with
quilt" part should not be needed - I hope.


> > 3. debian/README.Debian doesn't need to be in *.docs. See man
> > dh_installdocs:
> 
> Thanks, fixed.
> 
> > 4. Downloading
> > http://pypi.python.org/packages/source/d/distribute/distribute-0.6.14.tar.gz
> > Extracting in /tmp/tmpeY0G4V
> >
> > OUCH! buildds do not all have internet access. Your package should build
> > fine without that. Moreover the contents of the pulled in tarball could
> > be anything. Thus ensuring DFSG-free sources is virtually impossible
> > when external sources are pulled in.
> >
> > 5. Your package doesn't build in pbuilder:
> >
> > dpkg-source: warning: ignoring deletion of directory doc
> > dpkg-source: error: cannot represent change to
> > s3ql-1.0.1/distribute-0.6.14.tar.gz: binary file contents changed
> 
> That's weird, it works just fine here, and it also does not download
> anything but uses the existing python-setuptools. Can you tell me what
> commands you used to get this?

dpkg-source -x s3ql_1.0.1-1.dsc;cd s3ql-1.0.1;pdebuild

which spawns a fresh "unstable" pbuilder chroot and installs your listed
build-deps.

-- 
Best regards,
Kilian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20110627/9ff0884c/attachment.pgp>