[Python-apps-team] r8241 - in /packages/mercurial/trunk/debian: changelog patches/for_upstream__test_false_positive_kfreebsd.patch patches/series

[Javi Merino]

On Wed, Feb 29, 2012 at 02:21:20PM +0100, Julien Cristau wrote:
> Hi Javi,
> 
> On Wed, Feb 29, 2012 at 08:50:10 -0000, vicho at users.alioth.debian.org wrote:
> 
> > URL: http://svn.debian.org/wsvn/python-apps/packages/mercurial/trunk/debian/patches/for_upstream__test_false_positive_kfreebsd.patch?rev=8241&op=file
> > ==============================================================================
> > --- packages/mercurial/trunk/debian/patches/for_upstream__test_false_positive_kfreebsd.patch (added)
> > +++ packages/mercurial/trunk/debian/patches/for_upstream__test_false_positive_kfreebsd.patch Wed Feb 29 08:50:08 2012
> > @@ -1,0 +1,17 @@
> > +Author: Javi Merino <vicho at debian.org>
> > +Description: Fix a false positive fail in a test on kfreebsd-*
> > + test-inherit-mode fails on kfreebsd-* because of differences in the
> > + output of chmod.  This is not a real failure, so don't flag it as
> > + such.
> > +Forwarded: No
> > +--- a/tests/test-inherit-mode.t
> > ++++ b/tests/test-inherit-mode.t
> > +@@ -138,7 +138,7 @@
> > +   $ hg init setgid
> > +   $ cd setgid
> > +   $ chmod g+rwx .hg/store
> > +-  $ chmod g+s .hg/store 2> /dev/null
> > ++  $ chmod g+s .hg/store > /dev/null 2> /dev/null
> > +   $ mkdir dir
> > +   $ touch dir/file
> > +   $ hg ci -qAm 'add dir/file'
> > 
> Seems like the issue is rather that chmod is *returning* 1, not
> outputting it?  Not throwing its stderr away might actually help know
> why, I guess :)

Pfff, yes, I jumped the gun.  The testsuite ignores stderr.  I saw the
error in the build log and I thought "bah, that's easy, no need to test it
in a porterbox, just ignore stdout as well".  And then it failed again.

Reverted in r8254.  Cheers,
Javi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20120301/9462cd34/attachment.pgp>