[Python-apps-team] Bug#693093: xpra: please demote "ssh-askpass | ssh-askpass-fullscreen"

[Dmitry Smirnov]

tags 693093 wontfix moreinfo

--

Hi Jakub,

I'm very glad you're one of the Xpra users. :)
I also packaged its companion "winswitch" but it is waiting for sponsor.

On Tue, 13 Nov 2012 10:38:05 Jakub Wilk wrote:
> Dependency on "ssh-askpass | ssh-askpass-fullscreen" was added in this
> version of xpra. I don't know what was the reason for this addition
> (it's not documented in the changelog), but I can assure you that xpra
> works just fine without it.

No it doesn't. :(
In Xpra 0.7.2 upstream fixed the following issue: 

	https://www.xpra.org/trac/ticket/203

and silently introduced this dependency (it's not mentioned in #203 or 
changelog, neither upstream updated their debian packaging with this 
dependency). That's how I missed it with first upload of 0.7.2.

As I use public key authentication I didn't have any problems connecting to my 
usual Xpra session until yesterday when I tried to connect with 0.7.2 client 
from another computer which could connect only through SSH password 
authentication. To my surprise Xpra failed to display password prompt due to 
lack of ssh-askpass binary. So I promptly introduce ssh-askpass to Depends as 
it is a new genuine dependency.

> Please demote it to Recommends or Suggests,
> whichever is more appropriate.

I hope you'll agree with me that whatever is required for attaching with SSH 
password authentication is an essential and therefore qualifies for Depends.

Please advise if we can close this issue.


> (Also note that the ssh-askpass-fullscreen alternative appears to be
> redundant: ssh-askpass-fullscreen provides the ssh-askpass virtual
> package.)

I know.
Perhaps you're right and depenency on virtual package would be just enough, 
without explicit list of alternative(s).

I know it is unnecessary but do you think it could be something like

	"ssh-askpass-fullscreen | ssh-askpass". 

to promote a particular alternative?

Thanks.

Regards,
Dmitry.