[Python-apps-team] Bug#710991: xpra: some parts of windows can not be clicked after changing resolutions

[Timo Juhani Lindfors]

Package: xpra
Version: 0.9.4+dfsg-1
Severity: normal

Steps to reproduce:
1) xpra attach ssh:server.example.com:7
2) change resolution of the client machine to 640x480 temporarily
   (e.g. in gnome System->Preferences->Monitors)
3) change the resolution back to normal

Expected results:
3) all parts of xpra windows can be accessed with mouse

Actual results:
3) only a 640x480 pixel area in the upper left corner of each window
is accessible.

More info:
1) The only workaround I have found so far is to disconnect and
   reattach xpra.
2) The xpra server log shows how xpra continues to think that the
   resolution is 640x480 even after it has been set back to normal:

2013-06-03 21:25:16,371 New connection received: SocketConnection(/home/lindi/.xpra/sauna-7)
2013-06-03 21:25:16,619 Handshake complete; enabling connection
2013-06-03 21:25:16,621 Python/Gtk2 Linux client version 0.9.4 connected from 'sauna'
2013-06-03 21:25:16,621 mmap is enabled using 128MB area in /tmp/xpra.GUArsf.mmap
2013-06-03 21:25:16,621 max client resolution is 1680x1050 (from [[1680, 1050]]), current server resolution is 1024x768
2013-06-03 21:25:16,638 new resolution matching 1680x1050 : screen now set to 1680x1050
2013-06-03 21:25:16,639 setting key repeat rate from client: 500ms delay / 33ms interval
2013-06-03 21:25:16,642 keyboard mapping already configured (skipped)
2013-06-03 21:25:16,712 sending updated screen size to clients: 1680x1050 (max 5120x3200)
2013-06-03 21:25:28,471 new resolution matching 640x480 : screen now set to 640x480
2013-06-03 21:25:28,496 sending updated screen size to clients: 640x480 (max 5120x3200)

3) It seems that when I change the resolution from R1 to R2 xpra sets
   the screen size to R1 and not R2! Here is a patch that fixes the
   problem for me:

--- /usr/share/pyshared/xpra/client.py	  2013-05-27 07:21:53.000000000 +0300
+++ client.py				  2013-06-04 00:50:28.197672381 +0300
@@ -1106,8 +1106,9 @@
         self.encoding = encoding
         self.send("encoding", encoding)
 
-    def _screen_size_changed(self, *args):
-        root_w, root_h = get_root_size()
+    def _screen_size_changed(self, screen):
+        root_w = screen.get_width()
+        root_h = screen.get_height()
         log.debug("sending updated screen size to server: %sx%s", root_w, root_h)
         self.send("desktop_size", root_w, root_h, self.get_screen_sizes())
         #update the max packet size (may have gone up):


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xpra depends on:
ii  libavcodec53              6:0.8.7-1
ii  libc6                     2.17-4
ii  libswscale2               6:0.8.7-1
ii  libvpx1                   1.2.0-2
ii  libwebp2                  0.1.3-3+nmu1
ii  libx11-6                  2:1.5.0-1+deb7u1
ii  libx264-123               2:0.123.2189+git35cf912-1
ii  python                    2.7.3-5
ii  python-gtk2               2.24.0-3+b1
ii  python-wimpiggy           0.9.4+dfsg-1
ii  x11-xserver-utils         7.7~3
ii  xserver-xorg-input-void   1:1.4.0-1+b1
ii  xserver-xorg-video-dummy  1:0.3.5-2+b1

Versions of packages xpra recommends:
ii  openssh-client  1:6.2p2-3
ii  python-imaging  1.1.7-4
ii  ssh-askpass     1:1.2.4.1-9

Versions of packages xpra suggests:
ii  gstreamer0.10-plugins-bad   0.10.23-7.1
ii  gstreamer0.10-plugins-good  0.10.31-3+nmu1
ii  gstreamer0.10-plugins-ugly  0.10.19-2+b2
pn  openssh-server              <none>
pn  pulseaudio                  <none>
pn  pulseaudio-utils            <none>
ii  python-dbus                 1.2.0-1
pn  python-gst0.10              <none>
pn  python-gtkglext1            <none>

-- no debconf information