[Python-apps-team] Bug#710444: [RFR] templates://cloud-init/{cloud-init.templates}

Christian PERRIER bubulle at debian.org
Thu Jun 6 05:21:33 UTC 2013


Please find, for review, the debconf templates and packages descriptions for the cloud-init source package.

This review will last from Thursday, June 06, 2013 to Sunday, June 16, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- cloud-init.old/debian/cloud-init.templates	2013-05-30 22:31:36.110064510 +0200
+++ cloud-init/debian/cloud-init.templates	2013-06-02 19:18:28.781965541 +0200
@@ -2,11 +2,11 @@
 Type: multiselect
 Default: NoCloud, ConfigDrive, OVF, MAAS
 Choices-C: NoCloud, ConfigDrive, OVF, MAAS, Ec2
-Choices: NoCloud: Reads info from /var/lib/cloud/seed only, ConfigDrive: Reads data from Openstack Config Drive, OVF: Reads data from OVF Transports, MAAS: Reads data from Ubuntu MAAS, Ec2: reads data from EC2 Metadata service
-_Description: Which data sources should be searched?
+__Choices: /var/lib/cloud/seed only, Openstack Config Drive, OVF Transports, Ubuntu MAAS, EC2 Metadata service
+_Description: Data sources to read from:
  Cloud-init supports searching different "Data Sources" for information
  that it uses to configure a cloud instance.
  .
- Warning: Only select 'Ec2' if this system will be run on a system with
- the EC2 metadata service present.  Doing so incorrectly will result in
- a substantial timeout on boot.
+ Please note that "Ec2 Metadata service" should be used only if
+ the EC2 metadata service is present. Otherwise, it will trigger
+ a very noticeable timeout on boot.

Choices should be translatable, even more as they give details about
each choice (good idea, indeed, though it limits the length of details
that can be given).

We usually recommend to avoid paragraphs with "Warning", "Note" and
such thigns. Just be factual.

Standardize on double quotes.

--- cloud-init.old/debian/control	2013-05-30 22:31:36.110064510 +0200
+++ cloud-init/debian/control	2013-06-02 19:19:32.031153108 +0200
@@ -41,13 +41,11 @@
          python-requests,
          ${misc:Depends}
 Description: configuration and customization of cloud instances
- Framework and tool written in Python to handle early initialization of a
+ This package provides a framework and tool written in Python to handle early initialization of a
  cloud instance. Cloud-init can for example set a default locale and a host
  name, generate SSH private host keys, add SSH keys to a user's
  authorized_keys so they can log in, and set up ephemeral mount points.
  .
  Cloud-init's behavior can be configured via user-data, given by the user at
  instance launch time.
- .
- See upstream project for more details:
- https://help.ubuntu.com/community/CloudInit
+

First paragraph make a real sentence.

The last paragraph more belongs to a Homepage: field, imho.

-- 


-------------- next part --------------
Template: cloud-init/datasources
Type: multiselect
Default: NoCloud, ConfigDrive, OVF, MAAS
Choices-C: NoCloud, ConfigDrive, OVF, MAAS, Ec2
__Choices: /var/lib/cloud/seed only, Openstack Config Drive, OVF Transports, Ubuntu MAAS, EC2 Metadata service
_Description: Data sources to read from:
 Cloud-init supports searching different "Data Sources" for information
 that it uses to configure a cloud instance.
 .
 Please note that "Ec2 Metadata service" should be used only if
 the EC2 metadata service is present. Otherwise, it will trigger
 a very noticeable timeout on boot.
-------------- next part --------------
--- cloud-init.old/debian/cloud-init.templates	2013-05-30 22:31:36.110064510 +0200
+++ cloud-init/debian/cloud-init.templates	2013-06-02 19:18:28.781965541 +0200
@@ -2,11 +2,11 @@
 Type: multiselect
 Default: NoCloud, ConfigDrive, OVF, MAAS
 Choices-C: NoCloud, ConfigDrive, OVF, MAAS, Ec2
-Choices: NoCloud: Reads info from /var/lib/cloud/seed only, ConfigDrive: Reads data from Openstack Config Drive, OVF: Reads data from OVF Transports, MAAS: Reads data from Ubuntu MAAS, Ec2: reads data from EC2 Metadata service
-_Description: Which data sources should be searched?
+__Choices: /var/lib/cloud/seed only, Openstack Config Drive, OVF Transports, Ubuntu MAAS, EC2 Metadata service
+_Description: Data sources to read from:
  Cloud-init supports searching different "Data Sources" for information
  that it uses to configure a cloud instance.
  .
- Warning: Only select 'Ec2' if this system will be run on a system with
- the EC2 metadata service present.  Doing so incorrectly will result in
- a substantial timeout on boot.
+ Please note that "Ec2 Metadata service" should be used only if
+ the EC2 metadata service is present. Otherwise, it will trigger
+ a very noticeable timeout on boot.
--- cloud-init.old/debian/control	2013-05-30 22:31:36.110064510 +0200
+++ cloud-init/debian/control	2013-06-02 19:19:32.031153108 +0200
@@ -41,13 +41,11 @@
          python-requests,
          ${misc:Depends}
 Description: configuration and customization of cloud instances
- Framework and tool written in Python to handle early initialization of a
+ This package provides a framework and tool written in Python to handle early initialization of a
  cloud instance. Cloud-init can for example set a default locale and a host
  name, generate SSH private host keys, add SSH keys to a user's
  authorized_keys so they can log in, and set up ephemeral mount points.
  .
  Cloud-init's behavior can be configured via user-data, given by the user at
  instance launch time.
- .
- See upstream project for more details:
- https://help.ubuntu.com/community/CloudInit
+
-------------- next part --------------
Source: cloud-init
Maintainer: Python Applications Packaging Team <python-apps-team at lists.alioth.debian.org>
Uploaders: Charles Plessy <plessy at debian.org>,
           Miguel Landaeta <miguel at miguel.cc>,
           Julien Danjou <acid at debian.org>,
           Thomas Goirand <zigo at debian.org>
Section: admin
Priority: optional
Build-Depends: debhelper (>= 9),
               po-debconf,
               pyflakes,
               pylint,
               python,
               python-nose,
               python-mocker,
               python-configobj,
               python-oauth,
               python-boto (>= 2.3),
               python-cheetah,
               python-setuptools,
               python-yaml
Standards-Version: 3.9.3
Vcs-Browser: http://anonscm.debian.org/viewvc/python-apps/packages/cloud-init/trunk/
Vcs-Svn: svn://anonscm.debian.org/python-apps/packages/cloud-init/trunk/
Homepage: https://launchpad.net/cloud-init

Package: cloud-init
Architecture: all
Depends: lsb-base,
         ifupdown,
         procps,
         python,
         python (>= 2.7) | python-argparse,
         python-cheetah,
         python-configobj,
         python-oauth,
         python-software-properties,
         python-yaml,
         python-boto (>= 2.3),
         python-prettytable,
         python-requests,
         ${misc:Depends}
Description: configuration and customization of cloud instances
 This package provides a framework and tool written in Python to handle early initialization of a
 cloud instance. Cloud-init can for example set a default locale and a host
 name, generate SSH private host keys, add SSH keys to a user's
 authorized_keys so they can log in, and set up ephemeral mount points.
 .
 Cloud-init's behavior can be configured via user-data, given by the user at
 instance launch time.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20130606/cd7c969a/attachment.pgp>


More information about the Python-apps-team mailing list