[Python-apps-team] Bug#710444: [BTS#710444] templates://cloud-init/{cloud-init.templates} : Final update for English review

[Justin B Rye]

Charles Plessy wrote:
>  -Default: NoCloud, ConfigDrive, OVF, MAAS
>  +Default: NoCloud, ConfigDrive, AltCloud, OVF, MAAS, Ec2, CloudStack, None
> 
>  -Choices-C: NoCloud, ConfigDrive, OVF, MAAS, Ec2
>  +Choices-C: NoCloud, ConfigDrive, AltCloud, OVF, MAAS, Ec2, CloudStack, None
> 
>  -Choices: NoCloud: Reads info from /var/lib/cloud/seed only, ConfigDrive: Reads data from Openstack Config Drive, OVF: Reads data from OVF Transports, MAAS: Reads data from Ubuntu MAAS, Ec2: reads data from EC2 Metadata service
>  +Choices: NoCloud: Reads info from /var/lib/cloud/seed only, ConfigDrive: Reads data from Openstack Config Drive, AltCloud: config disks for RHEVm and vSphere, OVF: Reads data from OVF Transports, MAAS: Reads data from Ubuntu MAAS, Ec2: reads data from EC2 Metadata service, CloudStack: Read from CloudStack metadata service, None: Failsafe datasource

You're comparing it with the unreviewed version, again.  The LCFC had:

    __Choices: /var/lib/cloud/seed only, Openstack Config Drive, OVF Transports, Ubuntu MAAS, EC2 Metadata service

We don't need to repeat the "Reads data from" part; we just need to
add the datasources to the list.  The option name is also obvious and
unnecessary for almost all of them, and doesn't need to be repeated.
AltCloud seems to be an exception, so maybe it needs rephrasing.

Shouldn't "config disks" be "configuration disks"?  Oh - now I
remember doing this search before; it turns out they're either virtual
floppies or compact discs.  And does it really need to go into the
details of RHEVm and vSphere?  For a start, shouldn't that be RHEV-M?
I'm going to try guessing that AltCloud's parallel to OpenStack and
that each should just offer a "Config Drive".

And why are the choices in this order?  Shouldn't they be, say,
alphabetical by name, perhaps with NoCloud and None left out?

I would suggest:

   Default: NoCloud, AltCloud, CloudStack, ConfigDrive, Ec2, MAAS, OVF, None
   Choices-C: NoCloud, AltCloud, CloudStack, ConfigDrive, Ec2, MAAS, OVF, None
   Choices: /var/lib/cloud/seed only, AltCloud Config Drive, CloudStack metadata service, OpenStack Config Drive, EC2 Metadata service, Ubuntu MAAS, OVF Transports, Failsafe datasource

i.e.:
   Choices:
	/var/lib/cloud/seed only,
	AltCloud Config Drive,
	CloudStack metadata service,
	OpenStack Config Drive, 
	EC2 Metadata service,
	Ubuntu MAAS,
	OVF Transports,
	Failsafe datasource

Wait... if that first one uses no extra datasource besides the default
seed, and the last uses a failsafe datasource of some sort, why is the
latter called "None"?

Okay, I'm definitely still too unsure to offer a patch.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package