[Python-apps-team] Bug#751920: AttributeError: 'SubtitleFile' object has no attribute '_onlineFileId'

[Jan Braun]

Package: subdownloader
Version: 2.0.14-1.1
Severity: normal
Tags: patch

Hi,

Subdownloader just crashed on me with the following traceback:
| Traceback (most recent call last):
|   File "/usr/bin/subdownloader", line 79, in <module>
|     cli.start_session()
|   File "/usr/share/subdownloader/cli/main.py", line 107, in start_session
|     self.handle_operation(self.options.operation)
|   File "/usr/share/subdownloader/cli/main.py", line 156, in handle_operation
|     self.DownloadSubtitles(_filter.subtitles_to_download())
|   File "/usr/share/subdownloader/modules/filter.py", line 33, in subtitles_to_download
|     self.log.debug("- adding: %s: %s"% (subtitle.getIdFileOnline(), subtitle.getFileName()))
|   File "/usr/share/subdownloader/modules/subtitlefile.py", line 73, in getIdFileOnline
|     return self._onlineFileId
| AttributeError: 'SubtitleFile' object has no attribute '_onlineFileId'

It's deterministic with that set of videos, but works fine for others. Since
the bug and fix are obvious in the code (._onlineFileId and ._id_file_online
are supposed to be the same variable), I'm not wasting energy on figuring out
an exact reproduction recipe.

Patch attached, but it would be nice if you could package "current"
upstream instead, which I've verified to be fixed as well¹.

regards,
    Jan

¹although it keeps both, with _id_file_online initialized to the empty
string and never accessed otherwise. X)
-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (800, 'testing'), (550, 'unstable'), (10, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages subdownloader depends on:
ii  python               2.7.6-2
ii  python-crypto        2.6.1-5+b1
ii  python-kaa-metadata  0.7.7+svn4596-4
ii  python-support       1.0.15

Versions of packages subdownloader recommends:
ii  python-qt4  4.11+dfsg-1+b1

subdownloader suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subdownloader._onlineFileId.patch
Type: text/x-diff
Size: 565 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20140617/7a2bbc6e/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20140617/7a2bbc6e/attachment.sig>