[Python-apps-team] Bug#835937: beets: FTBFS randomly (test_nonexistent_file fails)

[Santiago Vila]

Package: src:beets
Version: 1.3.19-1
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with python2,sphinxdoc
   dh_testdir -i
   dh_update_autotools_config -i
   dh_auto_configure -i
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_build
	python setup.py build --force
running build
running build_py
creating build
creating build/lib.linux-x86_64-2.7

[... snipped, one of the tests fails, see the full build log ...]

make[1]: *** [override_dh_auto_test] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:4: recipe for target 'build-indep' failed
make: *** [build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

The failure happens randomly: It always happen in a certain
autobuilder I have, and it does never happen on the others.

I attach three different build logs, but you can also find failed
build logs here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/beets.html

By searching for the error message, however, one arrives to a bug
which is reported and fixed in github: Apparently, a file is mocked
but it's never explicitly unmocked (no idea what that means :-)

https://github.com/beetbox/beets/issues/2135

The fix for this bug may be found here:

https://github.com/beetbox/beets/pull/2137/files

and it's also attached.

I've tested the patch on the only autobuilder where it fails for me,
and now the test does not fail anymore.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: beets_1.3.19-1_amd64-20160829T100131Z.gz
Type: application/gzip
Size: 45949 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20160829/9544cff1/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: beets_1.3.19-1_amd64-20160829T103734Z.gz
Type: application/gzip
Size: 45913 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20160829/9544cff1/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: beets_1.3.19-1_amd64-20160829T110013Z.gz
Type: application/gzip
Size: 45923 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20160829/9544cff1/attachment-0005.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: beets.patch.txt
URL: <http://lists.alioth.debian.org/pipermail/python-apps-team/attachments/20160829/9544cff1/attachment-0001.txt>