[Python-apps-team] Bug#881474: phatch: please make the build reproducible

[Chris Lamb]

Source: phatch
Version: 0.2.7.1-5
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that phatch could not be built reproducibly.

This is due to the docs encoding a function name memory reference.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible_build.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/reproducible_build.patch	2017-11-12 08:04:10.267773715 +0000
@@ -0,0 +1,17 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-11-12
+
+--- phatch-0.2.7.1.orig/phatch/other/EXIF.py
++++ phatch-0.2.7.1/phatch/other/EXIF.py
+@@ -1295,7 +1295,9 @@ class EXIF_header:
+         return a
+ 
+     # return list of entries in this IFD
+-    def dump_IFD(self, ifd, ifd_name, dict=EXIF_TAGS, relative=0, stop_tag='UNDEF'):
++    def dump_IFD(self, ifd, ifd_name, dict=None, relative=0, stop_tag='UNDEF'):
++        if dict is None:
++            dict = EXIF_TAGS
+         entries=self.s2n(ifd, 2)
+         for i in range(entries):
+             # entry is index of start of this IFD in the file
--- a/debian/patches/series	2017-11-12 07:52:32.467257990 +0000
--- b/debian/patches/series	2017-11-12 08:04:09.039772258 +0000
@@ -3,3 +3,4 @@
 wxpy3.0-compat.patch
 fix-loading.patch
 bts823796.patch
+reproducible_build.patch