[Python-apps-team] Bug#882447: pyzor: please make the build reproducible

[Chris Lamb]

Source: pyzor
Version: 1:1.0.0-3
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that pyzor could not be built reproducibly.

This was because it was including the memory addresses of an internal
dispatch table in the documentation. We fix that by making them
"private."

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/reproducible-build.patch	1970-01-01 09:00:00.000000000 +0900
--- b/debian/patches/reproducible-build.patch	2017-11-23 10:34:09.956545410 +0900
@@ -0,0 +1,24 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-11-23
+
+--- pyzor-1.0.0.orig/pyzor/server.py
++++ pyzor-1.0.0/pyzor/server.py
+@@ -285,7 +285,7 @@ class RequestHandler(SocketServer.Datagr
+                               self.client_address[0])
+         # Get a handle to the appropriate method to execute this operation.
+         try:
+-            dispatch = self.dispatches[opcode]
++            dispatch = self._dispatches[opcode]
+         except KeyError:
+             raise NotImplementedError("Requested operation is not "
+                                       "implemented.")
+@@ -398,7 +398,7 @@ class RequestHandler(SocketServer.Datagr
+         self.response["Count"] = "%d" % record.r_count
+         self.response["WL-Count"] = "%d" % record.wl_count
+ 
+-    dispatches = {
++    _dispatches = {
+         'ping': None,
+         'pong': handle_pong,
+         'info': handle_info,
--- a/debian/patches/series	2017-11-23 10:30:38.825305023 +0900
--- b/debian/patches/series	2017-11-23 10:34:08.796510172 +0900
@@ -1 +1,2 @@
 remove-exernal-resources.patch
+reproducible-build.patch