[Python-apps-team] Bug#855092: beets: FTBFS randomly (failing tests)

[Santiago Vila]

tags 855092 + patch
thanks

Dear Stefano:

I did a "grep FAIL:" on the build logs and found that only three tests
are to blame for the build failures I'm experiencing.

If the package works ok "as is" and the failing tests do not mean that
the package is broken, please consider applying the patch below for
buster.

If you want to debug the failing tests and see why they fail, please
contact me privately and I will gladly offer ssh access to a machine
where it happens very easily.

Thanks.

diff -Nru beets-1.4.7/debian/changelog beets-1.4.7/debian/changelog
--- beets-1.4.7/debian/changelog	2018-08-20 17:55:31.000000000 +0200
+++ beets-1.4.7/debian/changelog	2019-04-21 18:30:42.000000000 +0200
@@ -1,3 +1,11 @@
+beets (1.4.7-3) unstable; urgency=medium
+
+  [ Santiago Vila ]
+  * Add patch skip-more-unreliable-tests to fix a FTBFS problem which
+    happens randomly in some build environments. (Closes: #855092)
+
+ -- Stefano Rivera <stefanor at debian.org>  Sun, 21 Apr 2019 18:30:42 +0200
+
 beets (1.4.7-2) unstable; urgency=medium
 
   * Use py3versions -s in autopkgtests, now that X-Python3-Version is dropped.
diff -Nru beets-1.4.7/debian/patches/series beets-1.4.7/debian/patches/series
--- beets-1.4.7/debian/patches/series	2018-08-20 17:55:31.000000000 +0200
+++ beets-1.4.7/debian/patches/series	2019-04-21 18:26:16.000000000 +0200
@@ -3,3 +3,4 @@
 skip-broken-test
 py37-compat
 skip-unreliable-tests
+skip-more-unreliable-tests
diff -Nru beets-1.4.7/debian/patches/skip-more-unreliable-tests beets-1.4.7/debian/patches/skip-more-unreliable-tests
--- beets-1.4.7/debian/patches/skip-more-unreliable-tests	1970-01-01 01:00:00.000000000 +0100
+++ beets-1.4.7/debian/patches/skip-more-unreliable-tests	2019-04-21 18:30:42.000000000 +0200
@@ -0,0 +1,37 @@
+From: Santiago Vila <sanvila at debian.org>
+Date: Sun, 21 Apr 2019 18:25:00 +0200
+Subject: skip more unreliable tests
+
+---
+ test/test_plugins.py    | 2 ++
+ test/test_thumbnails.py | 1 +
+ 2 files changed, 3 insertions(+)
+
+--- a/test/test_plugins.py
++++ b/test/test_plugins.py
+@@ -211,6 +211,7 @@
+             self.__copy_file(dest_path, metadata)
+             self.file_paths.append(dest_path)
+ 
++    @unittest.skip('unreliable')
+     def test_import_task_created(self):
+         import_files = [self.import_dir]
+         self._setup_import_session(singletons=False)
+@@ -233,6 +234,7 @@
+             u'  {0}'.format(displayable_path(self.file_paths[1])),
+         ])
+ 
++    @unittest.skip('unreliable')
+     def test_import_task_created_with_plugin(self):
+         class ToSingletonPlugin(plugins.BeetsPlugin):
+             def __init__(self):
+--- a/test/test_thumbnails.py
++++ b/test/test_thumbnails.py
+@@ -49,6 +49,7 @@
+ 
+     @patch('beetsplug.thumbnails.ThumbnailsPlugin._check_local_ok')
+     @patch('beetsplug.thumbnails.os.stat')
++    @unittest.skip('unreliable')
+     def test_add_tags(self, mock_stat, _):
+         plugin = ThumbnailsPlugin()
+         plugin.write_metadata = Mock()