[Python-apps-team] Bug#921824: terminator: Impossible to load a layout on startup after upgrading to 1.91-3

[Patrice Pillot]

Package: terminator
Version: 1.91-3
Severity: important

Dear Maintainer,

   * What led up to the situation?

I run `terminator -l some_layout_name` or `terminator -s`

   * What was the outcome of this action?

I got the following stack trace (same in both cases):

Traceback (most recent call last):
  File "/usr/bin/terminator", line 72, in <module>
    LAYOUTLAUNCHER=LayoutLauncher()
  File "/usr/share/terminator/terminatorlib/layoutlauncher.py", line 62, in __init__
    self.update_layouts()
  File "/usr/share/terminator/terminatorlib/layoutlauncher.py", line 75, in update_layouts
    for layout in sorted(layouts, cmp=lambda x,y: cmp(x.lower(), y.lower())):
TypeError: 'cmp' is an invalid keyword argument for sort()

   * What outcome did you expect instead?

I was expecting terminator would start with the requested layout as I
was used to (or the layout launcher window as the man page advertises).

Alternatively, after I run terminator with no options, I typed Alt-L to display
the layout launcher. This worked but the list is empty and I got the
following stack trace :

Traceback (most recent call last):
  File "/usr/share/terminator/terminatorlib/terminal.py", line 884, in on_keypress
    getattr(self, "key_" + mapping)()
  File "/usr/share/terminator/terminatorlib/terminal.py", line 1898, in key_layout_launcher
    LAYOUTLAUNCHER=LayoutLauncher()
  File "/usr/share/terminator/terminatorlib/layoutlauncher.py", line 62, in __init__
    self.update_layouts()
  File "/usr/share/terminator/terminatorlib/layoutlauncher.py", line 75, in update_layouts
    for layout in sorted(layouts, cmp=lambda x,y: cmp(x.lower(), y.lower())):
TypeError: 'cmp' is an invalid keyword argument for sort()

Thanks in advance for fixing this annoying bug.

phep

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8) (ignored: LC_ALL set to fr_FR.utf8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8) (ignored: LC_ALL set to fr_FR.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages terminator depends on:
ii  dbus-x11           1.12.12-1
ii  gir1.2-glib-2.0    1.58.3-2
ii  gir1.2-gtk-3.0     3.24.5-1
ii  gir1.2-pango-1.0   1.42.4-6
ii  gir1.2-vte-2.91    0.54.2-2
ii  python3            3.7.2-1
ii  python3-cairo      1.16.2-1+b1
ii  python3-configobj  5.0.6-3
ii  python3-dbus       1.2.8-3
ii  python3-gi         3.30.4-1
ii  python3-gi-cairo   3.30.4-1
ii  python3-psutil     5.5.0-1

Versions of packages terminator recommends:
ii  gir1.2-keybinder-3.0  0.3.2-1
ii  gir1.2-notify-0.7     0.7.7-4
ii  xdg-utils             1.1.3-1

terminator suggests no packages.

-- no debconf information