[Python-modules-commits] [python-aiohttp] 04/05: Backport changes in test/test_connector.py from upstream master branch

Piotr Ożarowski piotr at moszumanska.debian.org
Thu Jul 28 22:05:19 UTC 2016


This is an automated email from the git hooks/post-receive script.

piotr pushed a commit to branch master
in repository python-aiohttp.

commit c984567fdf8502b32af1233d6ff59bcb38feb48c
Author: Piotr Ożarowski <piotr at debian.org>
Date:   Thu Jul 28 23:52:30 2016 +0200

    Backport changes in test/test_connector.py from upstream master branch
---
 debian/changelog                    |   1 +
 debian/patches/series               |   1 +
 debian/patches/test_connector.patch | 202 ++++++++++++++++++++++++++++++++++++
 3 files changed, 204 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 3c41884..15ee4c8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,7 @@ python-aiohttp (0.22.4-1) unstable; urgency=medium
   [ Piotr Ożarowski ]
   * New upstream release
     - Add dependency on python3-multidict
+  * Backport changes in test/test_connector.py from upstream master branch
   * Standards-Version bumped to 3.9.8 (no changes needed)
 
  -- Piotr Ożarowski <piotr at debian.org>  Thu, 28 Jul 2016 23:32:19 +0200
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..c1f788c
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+test_connector.patch
diff --git a/debian/patches/test_connector.patch b/debian/patches/test_connector.patch
new file mode 100644
index 0000000..d1db412
--- /dev/null
+++ b/debian/patches/test_connector.patch
@@ -0,0 +1,202 @@
+diff --git a/tests/test_connector.py b/tests/test_connector.py
+index c8cffea..fddd387 100644
+--- a/tests/test_connector.py
++++ b/tests/test_connector.py
+@@ -14,8 +14,9 @@ import aiohttp
+ from aiohttp import web
+ from aiohttp import client
+ from aiohttp import helpers
+-from aiohttp.client import ClientResponse
++from aiohttp.client import ClientResponse, ClientRequest
+ from aiohttp.connector import Connection
++from aiohttp.test_utils import unused_port
+ 
+ 
+ class TestBaseConnector(unittest.TestCase):
+@@ -257,11 +258,9 @@ class TestBaseConnector(unittest.TestCase):
+         tr, proto = unittest.mock.Mock(), unittest.mock.Mock()
+         proto.is_connected.return_value = True
+ 
+-        class Req:
+-            host = 'host'
+-            port = 80
+-            ssl = False
+-            response = unittest.mock.Mock()
++        req = ClientRequest('GET', 'http://host:80',
++                            loop=self.loop,
++                            response_class=unittest.mock.Mock())
+ 
+         conn = aiohttp.BaseConnector(loop=self.loop)
+         key = ('host', 80, False)
+@@ -270,7 +269,7 @@ class TestBaseConnector(unittest.TestCase):
+         conn._create_connection.return_value = helpers.create_future(self.loop)
+         conn._create_connection.return_value.set_result((tr, proto))
+ 
+-        connection = self.loop.run_until_complete(conn.connect(Req()))
++        connection = self.loop.run_until_complete(conn.connect(req))
+         self.assertFalse(conn._create_connection.called)
+         self.assertEqual(connection._transport, tr)
+         self.assertEqual(connection._protocol, proto)
+@@ -483,11 +482,9 @@ class TestBaseConnector(unittest.TestCase):
+             tr, proto = unittest.mock.Mock(), unittest.mock.Mock()
+             proto.is_connected.return_value = True
+ 
+-            class Req:
+-                host = 'host'
+-                port = 80
+-                ssl = False
+-                response = unittest.mock.Mock()
++            req = ClientRequest('GET', 'http://host:80',
++                                loop=self.loop,
++                                response_class=unittest.mock.Mock())
+ 
+             conn = aiohttp.BaseConnector(loop=self.loop, limit=1)
+             key = ('host', 80, False)
+@@ -497,7 +494,7 @@ class TestBaseConnector(unittest.TestCase):
+                 self.loop)
+             conn._create_connection.return_value.set_result((tr, proto))
+ 
+-            connection1 = yield from conn.connect(Req())
++            connection1 = yield from conn.connect(req)
+             self.assertEqual(connection1._transport, tr)
+ 
+             self.assertEqual(1, len(conn._acquired[key]))
+@@ -507,7 +504,7 @@ class TestBaseConnector(unittest.TestCase):
+             @asyncio.coroutine
+             def f():
+                 nonlocal acquired
+-                connection2 = yield from conn.connect(Req())
++                connection2 = yield from conn.connect(req)
+                 acquired = True
+                 self.assertEqual(1, len(conn._acquired[key]))
+                 connection2.release()
+@@ -531,11 +528,9 @@ class TestBaseConnector(unittest.TestCase):
+             tr, proto = unittest.mock.Mock(), unittest.mock.Mock()
+             proto.is_connected.return_value = True
+ 
+-            class Req:
+-                host = 'host'
+-                port = 80
+-                ssl = False
+-                response = unittest.mock.Mock()
++            req = ClientRequest('GET', 'http://host:80',
++                                loop=self.loop,
++                                response_class=unittest.mock.Mock())
+ 
+             conn = aiohttp.BaseConnector(loop=self.loop, limit=1)
+             key = ('host', 80, False)
+@@ -545,14 +540,14 @@ class TestBaseConnector(unittest.TestCase):
+                 self.loop)
+             conn._create_connection.return_value.set_result((tr, proto))
+ 
+-            connection = yield from conn.connect(Req())
++            connection = yield from conn.connect(req)
+             self.assertEqual(connection._transport, tr)
+ 
+             self.assertEqual(1, len(conn._acquired[key]))
+ 
+             with self.assertRaises(asyncio.TimeoutError):
+                 # limit exhausted
+-                yield from asyncio.wait_for(conn.connect(Req), 0.01,
++                yield from asyncio.wait_for(conn.connect(req), 0.01,
+                                             loop=self.loop)
+             connection.close()
+         self.loop.run_until_complete(go())
+@@ -583,11 +578,10 @@ class TestBaseConnector(unittest.TestCase):
+             proto = unittest.mock.Mock()
+             proto.is_connected.return_value = True
+ 
+-            class Req:
+-                host = 'host'
+-                port = 80
+-                ssl = False
+-                response = unittest.mock.Mock(_should_close=False)
++            req = ClientRequest('GET', 'http://host:80',
++                                loop=self.loop,
++                                response_class=unittest.mock.Mock(
++                                    _should_close=False))
+ 
+             max_connections = 2
+             num_connections = 0
+@@ -629,7 +623,7 @@ class TestBaseConnector(unittest.TestCase):
+                     return
+                 num_requests += 1
+                 if not start:
+-                    connection = yield from conn.connect(Req())
++                    connection = yield from conn.connect(req)
+                     yield from asyncio.sleep(0, loop=self.loop)
+                     connection.release()
+                 tasks = [
+@@ -652,11 +646,9 @@ class TestBaseConnector(unittest.TestCase):
+             tr, proto = unittest.mock.Mock(), unittest.mock.Mock()
+             proto.is_connected.return_value = True
+ 
+-            class Req:
+-                host = 'host'
+-                port = 80
+-                ssl = False
+-                response = unittest.mock.Mock()
++            req = ClientRequest('GET', 'http://host:80',
++                                loop=self.loop,
++                                response_class=unittest.mock.Mock())
+ 
+             conn = aiohttp.BaseConnector(loop=self.loop, limit=1)
+             key = ('host', 80, False)
+@@ -666,7 +658,7 @@ class TestBaseConnector(unittest.TestCase):
+                 self.loop)
+             conn._create_connection.return_value.set_result((tr, proto))
+ 
+-            connection = yield from conn.connect(Req())
++            connection = yield from conn.connect(req)
+ 
+             self.assertEqual(1, len(conn._acquired))
+             conn.close()
+@@ -723,19 +715,12 @@ class TestHttpClientConnector(unittest.TestCase):
+         self.loop.close()
+         gc.collect()
+ 
+-    def find_unused_port(self):
+-        s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+-        s.bind(('127.0.0.1', 0))
+-        port = s.getsockname()[1]
+-        s.close()
+-        return port
+-
+     @asyncio.coroutine
+     def create_server(self, method, path, handler):
+         app = web.Application(loop=self.loop)
+         app.router.add_route(method, path, handler)
+ 
+-        port = self.find_unused_port()
++        port = unused_port()
+         self.handler = app.make_handler(keep_alive_on=False)
+         srv = yield from self.loop.create_server(
+             self.handler, '127.0.0.1', port)
+@@ -785,7 +770,7 @@ class TestHttpClientConnector(unittest.TestCase):
+             self.create_server('get', '/', handler)
+         )
+ 
+-        port = self.find_unused_port()
++        port = unused_port()
+         conn = aiohttp.TCPConnector(loop=self.loop,
+                                     local_addr=('127.0.0.1', port))
+ 
+@@ -845,14 +830,12 @@ class TestHttpClientConnector(unittest.TestCase):
+         resolver = unittest.mock.MagicMock()
+         connector = aiohttp.TCPConnector(resolver=resolver, loop=self.loop)
+ 
+-        class Req:
+-            host = '127.0.0.1'
+-            port = 80
+-            ssl = False
+-            response = unittest.mock.Mock()
++        req = ClientRequest('GET', 'http://127.0.0.1:{}'.format(unused_port()),
++                            loop=self.loop,
++                            response_class=unittest.mock.Mock())
+ 
+         with self.assertRaises(OSError):
+-            self.loop.run_until_complete(connector.connect(Req()))
++            self.loop.run_until_complete(connector.connect(req))
+ 
+         resolver.resolve.assert_not_called()
+ 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/python-modules/packages/python-aiohttp.git



More information about the Python-modules-commits mailing list