[Python-modules-commits] [shiboken] 09/13: don't *2 the object's identifier because this causes an

[Raphaël Hertzog]

This is an automated email from the git hooks/post-receive script.

hertzog pushed a commit to branch master
in repository shiboken.

commit f81122e4bfc41030165da0f4fcdd8a27fe477255
Author: Gilles Filippini <pini at debian.org>
Date:   Thu Aug 17 15:04:22 2017 +0200

    don't *2 the object's identifier because this causes an
    
     unsigned long overflow when the result is > ULONG_MAX
    Bug-Debian: http://bugs.debian.org/856133
---
 tests/libother/otherobjecttype.cpp                     | 2 +-
 tests/otherbinding/collector_external_operator_test.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/libother/otherobjecttype.cpp b/tests/libother/otherobjecttype.cpp
index 3b59182..7510453 100644
--- a/tests/libother/otherobjecttype.cpp
+++ b/tests/libother/otherobjecttype.cpp
@@ -25,6 +25,6 @@
 Collector&
 operator<<(Collector& collector, const OtherObjectType& obj)
 {
-    collector << obj.identifier()*2;
+    collector << obj.identifier();
     return collector;
 }
diff --git a/tests/otherbinding/collector_external_operator_test.py b/tests/otherbinding/collector_external_operator_test.py
index 3e05700..e4c87f8 100644
--- a/tests/otherbinding/collector_external_operator_test.py
+++ b/tests/otherbinding/collector_external_operator_test.py
@@ -46,7 +46,7 @@ class CollectorOtherObjectType(unittest.TestCase):
         collector = Collector()
         obj = OtherObjectType()
         collector << obj
-        self.assertEqual(collector.items()[0], obj.identifier() * 2)
+        self.assertEqual(collector.items()[0], obj.identifier())
 
 if __name__ == '__main__':
     unittest.main()

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/python-modules/packages/shiboken.git